[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-core-devel
Subject: Re: Review Request 110277: Fix broken web shortcuts
From: "Hrvoje Senjan" <hrvoje.senjan () gmail ! com>
Date: 2013-05-13 22:38:53
Message-ID: 20130513223853.14370.42276 () vidsolbach ! de
[Download RAW message or body]
> On May 13, 2013, 2:23 p.m., Commit Hook wrote:
> > This review has been submitted with commit \
> > 56e93089160557805f17863b848ac178bb8975a8 by Maarten De Meyer to branch master.
@Maarten, maybe the part about fixing query URL's could also go to KDE/4.10 branch?
- Hrvoje
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110277/#review32448
-----------------------------------------------------------
On May 13, 2013, 2:23 p.m., Maarten De Meyer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110277/
> -----------------------------------------------------------
>
> (Updated May 13, 2013, 2:23 p.m.)
>
>
> Review request for KDE Runtime.
>
>
> Description
> -------
>
> I have gone through and and tested most (if not all) of the default
> web shortcuts in kde-runtime.
>
> Changes: http://lists.kde.org/?l=kde-core-devel&m=136750251617156&w=2
>
>
> Diffs
> -----
>
> kurifilter-plugins/ikws/searchproviders/cia.desktop d39c38b
> kurifilter-plugins/ikws/searchproviders/backports.desktop 8ebdd67
> kurifilter-plugins/ikws/searchproviders/austronaut.desktop b6a5fe7
> kurifilter-plugins/ikws/searchproviders/amg.desktop ad9f70a
> kurifilter-plugins/ikws/searchproviders/altavista.desktop 4620f92
> kurifilter-plugins/ikws/searchproviders/acronym.desktop c93ad96
> kurifilter-plugins/ikws/searchproviders/citeseer.desktop 8158f03
> kurifilter-plugins/ikws/searchproviders/ctan.desktop 4a2807d
> kurifilter-plugins/ikws/searchproviders/feedster.desktop 13ff3d7
> kurifilter-plugins/ikws/searchproviders/foldoc.desktop 3a7608c
> kurifilter-plugins/ikws/searchproviders/freecode.desktop PRE-CREATION
> kurifilter-plugins/ikws/searchproviders/freshmeat.desktop 5e84ffa
> kurifilter-plugins/ikws/searchproviders/froogle.desktop 75318aa
> kurifilter-plugins/ikws/searchproviders/google_images.desktop 3c7a7b0
> kurifilter-plugins/ikws/searchproviders/google_movie.desktop 5755c3a
> kurifilter-plugins/ikws/searchproviders/google_shopping.desktop PRE-CREATION
> kurifilter-plugins/ikws/searchproviders/gracenote.desktop b96a51b
> kurifilter-plugins/ikws/searchproviders/jamendo.desktop 8d971bd
> kurifilter-plugins/ikws/searchproviders/katatudo.desktop 352b7b3
> kurifilter-plugins/ikws/searchproviders/kde_projects.desktop PRE-CREATION
> kurifilter-plugins/ikws/searchproviders/kde_websvn.desktop 1310fb0
> kurifilter-plugins/ikws/searchproviders/metacrawler.desktop 8d07aa7
> kurifilter-plugins/ikws/searchproviders/msdn.desktop 4ee9823
> kurifilter-plugins/ikws/searchproviders/nl-telephone.desktop 3827d71
> kurifilter-plugins/ikws/searchproviders/pgpkeys.desktop 1476496
> kurifilter-plugins/ikws/searchproviders/python.desktop 9542815
> kurifilter-plugins/ikws/searchproviders/qt.desktop df6b25f
> kurifilter-plugins/ikws/searchproviders/qt3.desktop 5204151
> kurifilter-plugins/ikws/searchproviders/qt4.desktop PRE-CREATION
> kurifilter-plugins/ikws/searchproviders/rfc.desktop 1ce3648
> kurifilter-plugins/ikws/searchproviders/technorati.desktop a10a8d7
> kurifilter-plugins/ikws/searchproviders/vimeo.desktop d32ab7e
> kurifilter-plugins/ikws/searchproviders/vivisimo.desktop 291150e
> kurifilter-plugins/tests/kurifiltertest.cpp dd18eba
>
> Diff: http://git.reviewboard.kde.org/r/110277/diff/
>
>
> Testing
> -------
>
> Tried every search at least once.
>
>
> Thanks,
>
> Maarten De Meyer
>
>
[Attachment #3 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/110277/">http://git.reviewboard.kde.org/r/110277/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On May 13th, 2013, 2:23 p.m. UTC, <b>Commit \
Hook</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This review has been submitted with commit \
56e93089160557805f17863b848ac178bb8975a8 by Maarten De Meyer to branch master.</pre> \
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">@Maarten, maybe the part \
about fixing query URL's could also go to KDE/4.10 branch?</pre> <br />
<p>- Hrvoje</p>
<br />
<p>On May 13th, 2013, 2:23 p.m. UTC, Maarten De Meyer wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for KDE Runtime.</div>
<div>By Maarten De Meyer.</div>
<p style="color: grey;"><i>Updated May 13, 2013, 2:23 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">I have gone through and and tested most (if not all) of the default web \
shortcuts in kde-runtime.
Changes: http://lists.kde.org/?l=kde-core-devel&m=136750251617156&w=2</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Tried every search at least once.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kurifilter-plugins/ikws/searchproviders/cia.desktop <span style="color: \
grey">(d39c38b)</span></li>
<li>kurifilter-plugins/ikws/searchproviders/backports.desktop <span style="color: \
grey">(8ebdd67)</span></li>
<li>kurifilter-plugins/ikws/searchproviders/austronaut.desktop <span style="color: \
grey">(b6a5fe7)</span></li>
<li>kurifilter-plugins/ikws/searchproviders/amg.desktop <span style="color: \
grey">(ad9f70a)</span></li>
<li>kurifilter-plugins/ikws/searchproviders/altavista.desktop <span style="color: \
grey">(4620f92)</span></li>
<li>kurifilter-plugins/ikws/searchproviders/acronym.desktop <span style="color: \
grey">(c93ad96)</span></li>
<li>kurifilter-plugins/ikws/searchproviders/citeseer.desktop <span style="color: \
grey">(8158f03)</span></li>
<li>kurifilter-plugins/ikws/searchproviders/ctan.desktop <span style="color: \
grey">(4a2807d)</span></li>
<li>kurifilter-plugins/ikws/searchproviders/feedster.desktop <span style="color: \
grey">(13ff3d7)</span></li>
<li>kurifilter-plugins/ikws/searchproviders/foldoc.desktop <span style="color: \
grey">(3a7608c)</span></li>
<li>kurifilter-plugins/ikws/searchproviders/freecode.desktop <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>kurifilter-plugins/ikws/searchproviders/freshmeat.desktop <span style="color: \
grey">(5e84ffa)</span></li>
<li>kurifilter-plugins/ikws/searchproviders/froogle.desktop <span style="color: \
grey">(75318aa)</span></li>
<li>kurifilter-plugins/ikws/searchproviders/google_images.desktop <span \
style="color: grey">(3c7a7b0)</span></li>
<li>kurifilter-plugins/ikws/searchproviders/google_movie.desktop <span style="color: \
grey">(5755c3a)</span></li>
<li>kurifilter-plugins/ikws/searchproviders/google_shopping.desktop <span \
style="color: grey">(PRE-CREATION)</span></li>
<li>kurifilter-plugins/ikws/searchproviders/gracenote.desktop <span style="color: \
grey">(b96a51b)</span></li>
<li>kurifilter-plugins/ikws/searchproviders/jamendo.desktop <span style="color: \
grey">(8d971bd)</span></li>
<li>kurifilter-plugins/ikws/searchproviders/katatudo.desktop <span style="color: \
grey">(352b7b3)</span></li>
<li>kurifilter-plugins/ikws/searchproviders/kde_projects.desktop <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>kurifilter-plugins/ikws/searchproviders/kde_websvn.desktop <span style="color: \
grey">(1310fb0)</span></li>
<li>kurifilter-plugins/ikws/searchproviders/metacrawler.desktop <span style="color: \
grey">(8d07aa7)</span></li>
<li>kurifilter-plugins/ikws/searchproviders/msdn.desktop <span style="color: \
grey">(4ee9823)</span></li>
<li>kurifilter-plugins/ikws/searchproviders/nl-telephone.desktop <span style="color: \
grey">(3827d71)</span></li>
<li>kurifilter-plugins/ikws/searchproviders/pgpkeys.desktop <span style="color: \
grey">(1476496)</span></li>
<li>kurifilter-plugins/ikws/searchproviders/python.desktop <span style="color: \
grey">(9542815)</span></li>
<li>kurifilter-plugins/ikws/searchproviders/qt.desktop <span style="color: \
grey">(df6b25f)</span></li>
<li>kurifilter-plugins/ikws/searchproviders/qt3.desktop <span style="color: \
grey">(5204151)</span></li>
<li>kurifilter-plugins/ikws/searchproviders/qt4.desktop <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>kurifilter-plugins/ikws/searchproviders/rfc.desktop <span style="color: \
grey">(1ce3648)</span></li>
<li>kurifilter-plugins/ikws/searchproviders/technorati.desktop <span style="color: \
grey">(a10a8d7)</span></li>
<li>kurifilter-plugins/ikws/searchproviders/vimeo.desktop <span style="color: \
grey">(d32ab7e)</span></li>
<li>kurifilter-plugins/ikws/searchproviders/vivisimo.desktop <span style="color: \
grey">(291150e)</span></li>
<li>kurifilter-plugins/tests/kurifiltertest.cpp <span style="color: \
grey">(dd18eba)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/110277/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic