[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Review Request 110390: Do not set Phonon KCM as changed at startup when using PulseAudio
From:       "Jan Grulich" <grulja () gmail ! com>
Date:       2013-05-11 18:46:18
Message-ID: 20130511184618.4736.64561 () vidsolbach ! de
[Download RAW message or body]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110390/
-----------------------------------------------------------

Review request for KDE Runtime.


Description
-------

This patch fixes a problem in Phonon KCM which is always set as changed when using \
PulseAudio. I made two changes. The first change is renaming of ready() signal from \
AudioSetup class to pulseAudioReady() which is connected to slot in KCM which sets \
PulseAudio to enabled in Phonon::DevicePreference. The second change is a new signal \
emitted when GUI is initialized and only when pulseAudioReady() signal was emitted \
before. This signal is connected to slot in KCM which inserts this widget to KCM and \
connects changed() signal to KCM changed() slot.


Diffs
-----

  phonon/kcm/audiosetup.h 4887efe 
  phonon/kcm/audiosetup.cpp 35dc4ca 
  phonon/kcm/main.h 277adfe 
  phonon/kcm/main.cpp 5d75cba 

Diff: http://git.reviewboard.kde.org/r/110390/diff/


Testing
-------


Thanks,

Jan Grulich


[Attachment #3 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/110390/">http://git.reviewboard.kde.org/r/110390/</a>
  </td>
    </tr>
   </table>
   <br />




<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for KDE Runtime.</div>
<div>By Jan Grulich.</div>







<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This patch fixes a problem in Phonon KCM which is always set as changed \
when using PulseAudio. I made two changes. The first change is renaming of ready() \
signal from AudioSetup class to pulseAudioReady() which is connected to slot in KCM \
which sets PulseAudio to enabled in Phonon::DevicePreference. The second change is a \
new signal emitted when GUI is initialized and only when pulseAudioReady() signal was \
emitted before. This signal is connected to slot in KCM which inserts this widget to \
KCM and connects changed() signal to KCM changed() slot.</pre>  </td>
 </tr>
</table>





<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>phonon/kcm/audiosetup.h <span style="color: grey">(4887efe)</span></li>

 <li>phonon/kcm/audiosetup.cpp <span style="color: grey">(35dc4ca)</span></li>

 <li>phonon/kcm/main.h <span style="color: grey">(277adfe)</span></li>

 <li>phonon/kcm/main.cpp <span style="color: grey">(5d75cba)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/110390/diff/" style="margin-left: \
3em;">View Diff</a></p>







  </td>
 </tr>
</table>




  </div>
 </body>
</html>



[prev in list] [next in list] [prev in thread] [next in thread]

Configure | About | News | Add a list | Sponsored by KoreLogic