[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: kde review kartesio
From:       Anne-Marie Mahfouf <annemarie.mahfouf () free ! fr>
Date:       2013-05-10 11:58:06
Message-ID: 55516985.127663241.1368187086738.JavaMail.root () spooler3-g27 ! priv ! proxad ! net
[Download RAW message or body]

Hi,

A few primary remarks:
- libzorbaneural is needed but my distro does not have anything with "neural" in it \
(OpenSuse 12.3) what repo do I need to add in order to get it? The libzorbaneural \
website should be added to the cmake file so people can find this and packagers can \
                add it to their distros. 
- I see a screenshot folder and some .pro files that probably are not needed
- some doxygen comments for the variables in the .h files would be appreciated, if \
                anyone else wants to fix bugs it'll help a lot.
- Kartesio does not build for me, I get \
"/home/kde-devel/kartesio/src/calculations.cpp:278:1: error: control reaches end of \
                non-void function [-Werror=return-type]
cc1plus: some warnings being treated as errors"
- I don't see a Messages.sh file to extract translatable strings.
- I am not comfortable with the rm call line 181 in calculations.cpp => you can \
probably use more Qt classes here and in other parts of this file too. 

That's only a quick review as I couldn't run the app yet.

Tomaz, as for the user base maybe we could start a module for advanced scientific \
tools?

Best regards,

Anne-Marie


----- Mail original -----
> De: "Tomaz Canabrava" <tcanabrava@kde.org>
> À: "Anne-Marie Mahfouf" <annemarie.mahfouf@free.fr>
> Cc: "LucaTringali" <TRINGALINVENT@libero.it>, kde-core-devel@kde.org
> Envoyé: Vendredi 10 Mai 2013 12:28:54
> Objet: Re: kde review kartesio
> 
> 
> 
> Quite Unlikely ...
> 
> It's a Solver, to fit curves into points, That's very used in any
> theorical research, engeniering, math, phisics, etc.
> 
> 
> 
> 
> 
> 
> 
> 
> 
> 2013/5/10 Anne-Marie Mahfouf < annemarie.mahfouf@free.fr >
> 
> 
> Hi,
> 
> I am wondering what is the user base for this application as it seems
> quite specialized (I did not build it yet though). Can you tell us
> more about the potential target? Another question that comes to mind
> is: can't it be a feature of an existing KDE Edu apps?
> 
> Best regards,
> 
> Anne-Marie
> 
> ----- Mail original -----
> > De: "LucaTringali" < TRINGALINVENT@libero.it >
> > À: kde-core-devel@kde.org
> > Envoyé: Jeudi 9 Mai 2013 18:06:16
> > Objet: kde review kartesio
> 
> > 
> > 
> > 
> > Hello,
> > 
> > I have been working on Kartesio, a program for calculating best fit
> > curves with experimental points. I think it is ready to be moved in
> > the KDE Edu main repo now, so I'm asking your approval.
> > 
> > I followed the guidelines (
> > http://techbase.kde.org/Policies/Application_Lifecycle ) and
> 
> 
> > Kartesio is actually in KDE review:
> > 
> > https://projects.kde.org/projects/kdereview/kartesio
> > 
> > For any question, ask me.
> > 
> > 
> > 
> > 
> > Luca Tringali
> > 
> 
> 


[prev in list] [next in list] [prev in thread] [next in thread]