[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-core-devel
Subject: Re: Review Request 108802: Switch Delete/Move To Trash actions when Shift key is pressed in Konquero
From: "David Faure" <faure () kde ! org>
Date: 2013-05-05 22:16:29
Message-ID: 20130505221629.4715.55129 () vidsolbach ! de
[Download RAW message or body]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108802/#review32111
-----------------------------------------------------------
Thanks for taking care of this! Just a few comments.
dolphin/src/dolphinpart.cpp
<http://git.reviewboard.kde.org/r/108802/#comment23909>
This if() is not useful, delete NULL is fine.
dolphin/src/dolphinpart.cpp
<http://git.reviewboard.kde.org/r/108802/#comment23910>
Shouldn't this be done only if addDel is true, as it was before?
dolphin/src/dolphinpart.cpp
<http://git.reviewboard.kde.org/r/108802/#comment23911>
Same code as in dolphincontextmenu. If it can't be shared, at least there should \
be a comment about where the code comes from, for easier maintainance.
dolphin/src/dolphinpart.cpp
<http://git.reviewboard.kde.org/r/108802/#comment23912>
There are other ways to bring the context menu than the right button. There's the \
context key, too. So better watch for the QEvent::ContextMenu event instead of \
hardcoding "release of right button", if it really has to be done with the event \
filter.
- David Faure
On May 5, 2013, 1:53 p.m., Dawit Alemayehu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108802/
> -----------------------------------------------------------
>
> (Updated May 5, 2013, 1:53 p.m.)
>
>
> Review request for KDE Base Apps, David Faure and Frank Reininghaus.
>
>
> Description
> -------
>
> This patch fixes DolphinPart such that the "Delete/Move To Trash" actions are \
> automatically toggled if the user presses the Shift key and allows \
> https://git.reviewboard.kde.org/r/107509/ to be applied.
> The code is completely based on what Dolphin's context menu does. Even though this \
> works as planned, I still have reservations about the use of KModifierKeyInfo since \
> every key press event from any application is sent to the application that connects \
> to its signals. In my code and unlike what is done in Dolphin's context menu, I try \
> to mitigate the impact of that by ignoring the signal when the part does not have \
> the focus. Still if there is a better way to capture key press events at the part \
> level I would like to use that instead. Any ideas ?
>
> Diffs
> -----
>
> dolphin/src/dolphinpart.h 7881ded
> dolphin/src/dolphinpart.cpp 627ba79
>
> Diff: http://git.reviewboard.kde.org/r/108802/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Dawit Alemayehu
>
>
[Attachment #3 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/108802/">http://git.reviewboard.kde.org/r/108802/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Thanks for taking care \
of this! Just a few comments.</pre> <br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/108802/diff/2/?file=142264#file142264line464" \
style="color: black; font-weight: bold; text-decoration: \
underline;">dolphin/src/dolphinpart.cpp</a> <span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void \
DolphinPart::slotOpenContextMenu(const QPoint& pos,</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">464</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> \
<span class="k">if</span> <span class="p">(</span><span \
class="n">m_removeAction</span><span class="p">)</span> <span \
class="p">{</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This if() \
is not useful, delete NULL is fine.</pre> </div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/108802/diff/2/?file=142264#file142264line469" \
style="color: black; font-weight: bold; text-decoration: \
underline;">dolphin/src/dolphinpart.cpp</a> <span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void \
DolphinPart::slotOpenContextMenu(const QPoint& pos,</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">453</font></th> <td bgcolor="#ffffff" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">editActions</span><span class="p">.</span><span \
class="n">append</span><span class="p">(</span><span \
class="n">actionCollection</span><span class="p">()</span><span \
class="o">-></span><span class="n">action</span><span class="p">(</span><span \
class="s">"delete"</span><span class="p">));</span></pre></td> <th \
bgcolor="#f0f0f0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">468</font></th> <td bgcolor="#ffffff" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> \
<span class="n">editActions</span><span class="p">.</span><span \
class="n">append</span><span class="p">(</span><span \
class="n">actionCollection</span><span class="p">()</span><span \
class="o">-></span><span class="n">action</span><span class="p">(</span><span \
class="s">"delete"</span><span class="p">));</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Shouldn't this be done only if addDel is true, as it was \
before?</pre> </div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/108802/diff/2/?file=142264#file142264line623" \
style="color: black; font-weight: bold; text-decoration: \
underline;">dolphin/src/dolphinpart.cpp</a> <span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">622</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="kt">void</span> <span class="n">DolphinPart</span><span \
class="o">::</span><span class="n">updateRemoveAction</span><span \
class="p">()</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Same code \
as in dolphincontextmenu. If it can't be shared, at least there should be a \
comment about where the code comes from, for easier maintainance.</pre> </div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/108802/diff/2/?file=142264#file142264line664" \
style="color: black; font-weight: bold; text-decoration: \
underline;">dolphin/src/dolphinpart.cpp</a> <span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">663</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> \
<span class="k">if</span> <span class="p">(</span><span class="n">ev</span><span \
class="o">-></span><span class="n">button</span><span class="p">()</span> <span \
class="o">==</span> <span class="n">Qt</span><span class="o">::</span><span \
class="n">RightButton</span><span class="p">)</span> <span \
class="p">{</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">There are \
other ways to bring the context menu than the right button. There's the context \
key, too. So better watch for the QEvent::ContextMenu event instead of hardcoding \
"release of right button", if it really has to be done with the event \
filter.</pre> </div>
<br />
<p>- David</p>
<br />
<p>On May 5th, 2013, 1:53 p.m. UTC, Dawit Alemayehu wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for KDE Base Apps, David Faure and Frank Reininghaus.</div>
<div>By Dawit Alemayehu.</div>
<p style="color: grey;"><i>Updated May 5, 2013, 1:53 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This patch fixes DolphinPart such that the "Delete/Move To \
Trash" actions are automatically toggled if the user presses the Shift key and \
allows https://git.reviewboard.kde.org/r/107509/ to be applied.
The code is completely based on what Dolphin's context menu does. Even though \
this works as planned, I still have reservations about the use of KModifierKeyInfo \
since every key press event from any application is sent to the application that \
connects to its signals. In my code and unlike what is done in Dolphin's context \
menu, I try to mitigate the impact of that by ignoring the signal when the part does \
not have the focus. Still if there is a better way to capture key press events at the \
part level I would like to use that instead. Any ideas ?</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>dolphin/src/dolphinpart.h <span style="color: grey">(7881ded)</span></li>
<li>dolphin/src/dolphinpart.cpp <span style="color: grey">(627ba79)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/108802/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic