[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: Review Request 110315: Also recognize an openSUSE/SUSE installation and create the kdm user and
From:       "Oswald Buddenhagen" <ossi () kde ! org>
Date:       2013-05-05 13:09:51
Message-ID: 20130505130951.16118.3986 () vidsolbach ! de
[Download RAW message or body]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110315/#review32080
-----------------------------------------------------------

Ship it!


Ship It!

- Oswald Buddenhagen


On May 5, 2013, 12:02 p.m., Raymond Wooninck wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110315/
> -----------------------------------------------------------
> 
> (Updated May 5, 2013, 12:02 p.m.)
> 
> 
> Review request for kde-workspace, Luboš Luňák and Oswald Buddenhagen.
> 
> 
> Description
> -------
> 
> This patch allows for the recognition of an openSUSE/SUSE installation and utilizes \
> the correct tools to create the kdm user and group. This would fix an very old \
> situation where at this moment only debian installations were recognized and \
> properly handled. 
> The code follows the coding for debian
> 
> 
> Diffs
> -----
> 
> kdm/kfrontend/genkdmconf.c 69b42f1 
> 
> Diff: http://git.reviewboard.kde.org/r/110315/diff/
> 
> 
> Testing
> -------
> 
> Testing has been done on a couple of openSUSE systems and here the user and group \
> were properly created and no more error messages were shown.  
> 
> Thanks,
> 
> Raymond Wooninck
> 
> 


[Attachment #3 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/110315/">http://git.reviewboard.kde.org/r/110315/</a>
  </td>
    </tr>
   </table>
   <br />



 <p>Ship it!</p>



 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ship It!</pre>  <br />









<p>- Oswald</p>


<br />
<p>On May 5th, 2013, 12:02 p.m. UTC, Raymond Wooninck wrote:</p>








<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for kde-workspace, Luboš Luňák and Oswald Buddenhagen.</div>
<div>By Raymond Wooninck.</div>


<p style="color: grey;"><i>Updated May 5, 2013, 12:02 p.m.</i></p>






<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This patch allows for the recognition of an openSUSE/SUSE installation \
and utilizes the correct tools to create the kdm user and group. This would fix an \
very old situation where at this moment only debian installations were recognized and \
properly handled.

The code follows the coding for debian</pre>
  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Testing has been done on a couple of openSUSE systems and here the user \
and group were properly created and no more error messages were shown. </pre>  </td>
 </tr>
</table>




<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>kdm/kfrontend/genkdmconf.c <span style="color: grey">(69b42f1)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/110315/diff/" style="margin-left: \
3em;">View Diff</a></p>







  </td>
 </tr>
</table>








  </div>
 </body>
</html>



[prev in list] [next in list] [prev in thread] [next in thread]

Configure | About | News | Add a list | Sponsored by KoreLogic