From kde-core-devel Fri May 03 18:25:29 2013 From: "Marco Martin" Date: Fri, 03 May 2013 18:25:29 +0000 To: kde-core-devel Subject: Re: Review Request 110118: wrong path for plugin. ( doubling the plugin address cause the basepath t Message-Id: <20130503182529.28049.65774 () vidsolbach ! de> X-MARC-Message: https://marc.info/?l=kde-core-devel&m=136760556224108 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============2667247819125557893==" --===============2667247819125557893== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110118/#review31957 ----------------------------------------------------------- Ship it! Ship It! - Marco Martin On April 21, 2013, 6:18 p.m., Ömer Fadıl Usta wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/110118/ > ----------------------------------------------------------- > > (Updated April 21, 2013, 6:18 p.m.) > > > Review request for kde-workspace, Aaron J. Seigo and Marco Martin. > > > Description > ------- > > plasma-desktop(7470)/libplasma Plasma::PackageStructure::setPath: "/home/usta/kde/inst/master/share/apps/plasma/packages/org.kde.desktop.activitymanager//org.kde.desktop.activitymanager" invalid, basePath is "" > > it resets basePath due to double pluginname at the end of path. > > > Diffs > ----- > > plasma/desktop/shell/activitymanager/activitymanager.cpp 2ecb30d > > Diff: http://git.reviewboard.kde.org/r/110118/diff/ > > > Testing > ------- > > After this patch that warning about invalid path is gone. I have checked that package->path() returning correct address now. > > > Thanks, > > Ömer Fadıl Usta > > --===============2667247819125557893== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit
This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110118/

Ship it!

Ship It!

- Marco


On April 21st, 2013, 6:18 p.m. UTC, Ömer Fadıl Usta wrote:

Review request for kde-workspace, Aaron J. Seigo and Marco Martin.
By Ömer Fadıl Usta.

Updated April 21, 2013, 6:18 p.m.

Description 

plasma-desktop(7470)/libplasma Plasma::PackageStructure::setPath: "/home/usta/kde/inst/master/share/apps/plasma/packages/org.kde.desktop.activitymanager//org.kde.desktop.activitymanager" invalid, basePath is ""

it resets basePath due to double pluginname at the end of path.

Testing 

After this patch that warning about invalid path is gone. I have checked that package->path() returning correct address now.

Diffs

  • plasma/desktop/shell/activitymanager/activitymanager.cpp (2ecb30d)

View Diff
--===============2667247819125557893==--