[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-core-devel
Subject: Review Request 110285: Fixed warning message when user trying to set more than 8 keyboard layouts
From: "Victor Polevoy" <vityatheboss () gmail ! com>
Date: 2013-05-03 11:00:48
Message-ID: 20130503110048.17349.48858 () vidsolbach ! de
[Download RAW message or body]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110285/
-----------------------------------------------------------
Review request for kde-workspace.
Description
-------
If user trying to set more than 8 keyboard layouts in System Settings/Input \
devices/Keyboard layouts he sees a warning that he can't set more than 4 keyboard \
layouts but there should be "8".
My patch fixes typo in the warning message.
This addresses bug 285562.
http://bugs.kde.org/show_bug.cgi?id=285562
Diffs
-----
kcontrol/keyboard/kcm_keyboard_widget.cpp e513a41
kcontrol/keyboard/x11_helper.h 31f76f9
kcontrol/keyboard/x11_helper.cpp ebd09f3
Diff: http://git.reviewboard.kde.org/r/110285/diff/
Testing
-------
Yes, it works for me.
Thanks,
Victor Polevoy
[Attachment #3 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/110285/">http://git.reviewboard.kde.org/r/110285/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kde-workspace.</div>
<div>By Victor Polevoy.</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">If user trying to set more than 8 keyboard layouts in System \
Settings/Input devices/Keyboard layouts he sees a warning that he can't set more \
than 4 keyboard layouts but there should be "8".
My patch fixes typo in the warning message.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Yes, it works for me.</pre> </td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=285562">285562</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kcontrol/keyboard/kcm_keyboard_widget.cpp <span style="color: \
grey">(e513a41)</span></li>
<li>kcontrol/keyboard/x11_helper.h <span style="color: grey">(31f76f9)</span></li>
<li>kcontrol/keyboard/x11_helper.cpp <span style="color: grey">(ebd09f3)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/110285/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic