[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-core-devel
Subject: Re: Review Request 110083: Make kdepim libs optional dependency for libkfbapi
From: "Kevin Krammer" <krammer () kde ! org>
Date: 2013-05-03 6:43:40
Message-ID: 20130503064340.24570.56490 () vidsolbach ! de
[Download RAW message or body]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110083/#review31926
-----------------------------------------------------------
CMakeLists.txt
<http://git.reviewboard.kde.org/r/110083/#comment23805>
I would change that to WITH_KDEPIMLIBS, i.e. without underscore between KDEPIM \
and LIBS. For me KDEPIM_LIBS suggests libraries from module kdepim, while this is \
about libraries from kdepimlibs
libkfbapi/kdepim-utils.h
<http://git.reviewboard.kde.org/r/110083/#comment23806>
I think you could forward declare Addressee here
libkfbapi/kdepim-utils.h
<http://git.reviewboard.kde.org/r/110083/#comment23807>
those two most likely as well
libkfbapi/kdepim-utils.cpp
<http://git.reviewboard.kde.org/r/110083/#comment23808>
how do you arrive at this value? is this documented somewhere?
- Kevin Krammer
On April 29, 2013, 11:18 a.m., Martin Klapetek wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110083/
> -----------------------------------------------------------
>
> (Updated April 29, 2013, 11:18 a.m.)
>
>
> Review request for kdelibs and KDEPIM-Libraries.
>
>
> Description
> -------
>
> kdepim-libs are needed in the facebook library only to return user info as \
> KABC::Addressee and note as KMime::Message, plus events use KCalCore classes. This \
> patch makes dependency on kdepim-libs optional and disables building the event \
> classes completely in case kdepim-libs was not found.
>
> Diffs
> -----
>
> CMakeLists.txt 5aefdcf
> LibKFbAPI-KDEPIM.pc.in PRE-CREATION
> LibKFbAPI-KDEPIMConfig.cmake.in PRE-CREATION
> LibKFbAPI.pc.in af537d1
> libkfbapi/CMakeLists.txt dac62bc
> libkfbapi/commentinfo.h e5578c7
> libkfbapi/kdepim-utils.h PRE-CREATION
> libkfbapi/kdepim-utils.cpp PRE-CREATION
> libkfbapi/likeinfo.h e06052e
> libkfbapi/noteinfo.h 2492db1
> libkfbapi/noteinfo.cpp 154593d
> libkfbapi/notificationinfo.h a882694
> libkfbapi/userinfo.h ac22a7e
> libkfbapi/userinfo.cpp 26c64da
> libkfbapi/userinfoparser_p.h 0189a17
>
> Diff: http://git.reviewboard.kde.org/r/110083/diff/
>
>
> Testing
> -------
>
> Builds correctly here in both cases
>
>
> Thanks,
>
> Martin Klapetek
>
>
[Attachment #3 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/110083/">http://git.reviewboard.kde.org/r/110083/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/110083/diff/4/?file=141383#file141383line18" \
style="color: black; font-weight: bold; text-decoration: \
underline;">CMakeLists.txt</a> <span style="font-weight: normal;">
(Diff revision 4)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">18</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="nb">set</span><span class="p">(</span><span class="s">WITH_KDEPIM_LIBS</span> \
<span class="o">${</span><span class="nv">KdepimLibs_FOUND</span><span \
class="o">}</span><span class="p">)</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I would \
change that to WITH_KDEPIMLIBS, i.e. without underscore between KDEPIM and LIBS. For \
me KDEPIM_LIBS suggests libraries from module kdepim, while this is about libraries \
from kdepimlibs</pre> </div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/110083/diff/4/?file=141389#file141389line4" \
style="color: black; font-weight: bold; text-decoration: \
underline;">libkfbapi/kdepim-utils.h</a> <span style="font-weight: normal;">
(Diff revision 4)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">4</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="cp">#include <KABC/Addressee></span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I think you \
could forward declare Addressee here</pre> </div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/110083/diff/4/?file=141389#file141389line7" \
style="color: black; font-weight: bold; text-decoration: \
underline;">libkfbapi/kdepim-utils.h</a> <span style="font-weight: normal;">
(Diff revision 4)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">7</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="cp">#include "userinfo.h"</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">those two \
most likely as well</pre> </div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/110083/diff/4/?file=141390#file141390line4" \
style="color: black; font-weight: bold; text-decoration: \
underline;">libkfbapi/kdepim-utils.cpp</a> <span style="font-weight: normal;">
(Diff revision 4)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">4</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="k">static</span> <span class="k">const</span> <span class="kt">int</span> \
<span class="n">invalidTimezone</span> <span class="o">=</span> <span \
class="mi">42</span><span class="p">;</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">how do you \
arrive at this value? is this documented somewhere?</pre> </div>
<br />
<p>- Kevin</p>
<br />
<p>On April 29th, 2013, 11:18 a.m. UTC, Martin Klapetek wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kdelibs and KDEPIM-Libraries.</div>
<div>By Martin Klapetek.</div>
<p style="color: grey;"><i>Updated April 29, 2013, 11:18 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">kdepim-libs are needed in the facebook library only to return user info \
as KABC::Addressee and note as KMime::Message, plus events use KCalCore classes. This \
patch makes dependency on kdepim-libs optional and disables building the event \
classes completely in case kdepim-libs was not found.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Builds correctly here in both cases</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(5aefdcf)</span></li>
<li>LibKFbAPI-KDEPIM.pc.in <span style="color: grey">(PRE-CREATION)</span></li>
<li>LibKFbAPI-KDEPIMConfig.cmake.in <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>LibKFbAPI.pc.in <span style="color: grey">(af537d1)</span></li>
<li>libkfbapi/CMakeLists.txt <span style="color: grey">(dac62bc)</span></li>
<li>libkfbapi/commentinfo.h <span style="color: grey">(e5578c7)</span></li>
<li>libkfbapi/kdepim-utils.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>libkfbapi/kdepim-utils.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>libkfbapi/likeinfo.h <span style="color: grey">(e06052e)</span></li>
<li>libkfbapi/noteinfo.h <span style="color: grey">(2492db1)</span></li>
<li>libkfbapi/noteinfo.cpp <span style="color: grey">(154593d)</span></li>
<li>libkfbapi/notificationinfo.h <span style="color: grey">(a882694)</span></li>
<li>libkfbapi/userinfo.h <span style="color: grey">(ac22a7e)</span></li>
<li>libkfbapi/userinfo.cpp <span style="color: grey">(26c64da)</span></li>
<li>libkfbapi/userinfoparser_p.h <span style="color: grey">(0189a17)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/110083/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic