[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: Review Request 110259: Fix kurifiltertest to use the new google query
From:       "Commit Hook" <null () kde ! org>
Date:       2013-05-02 19:31:02
Message-ID: 20130502193102.16595.20237 () vidsolbach ! de
[Download RAW message or body]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110259/#review31912
-----------------------------------------------------------


This review has been submitted with commit 856b89dc43b8551c84629214138e4eebe63538b6 \
by Maarten De Meyer to branch master.

- Commit Hook


On May 1, 2013, 6:41 p.m., Maarten De Meyer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110259/
> -----------------------------------------------------------
> 
> (Updated May 1, 2013, 6:41 p.m.)
> 
> 
> Review request for KDE Runtime.
> 
> 
> Description
> -------
> 
> My previous review (https://git.reviewboard.kde.org/r/109841/) broke \
> kurifiltertest. 
> The google web shortcut has been changed to use https. This made the kurifilter \
> unit test fail some tests. Changed the unit test to check for https.
> 
> 
> Diffs
> -----
> 
> kurifilter-plugins/tests/kurifiltertest.cpp 4677a91 
> 
> Diff: http://git.reviewboard.kde.org/r/110259/diff/
> 
> 
> Testing
> -------
> 
> All tests pass.
> 
> 
> Thanks,
> 
> Maarten De Meyer
> 
> 


[Attachment #3 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/110259/">http://git.reviewboard.kde.org/r/110259/</a>
  </td>
    </tr>
   </table>
   <br />





 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been \
submitted with commit 856b89dc43b8551c84629214138e4eebe63538b6 by Maarten De Meyer to \
branch master.</pre>  <br />









<p>- Commit</p>


<br />
<p>On May 1st, 2013, 6:41 p.m. UTC, Maarten De Meyer wrote:</p>








<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for KDE Runtime.</div>
<div>By Maarten De Meyer.</div>


<p style="color: grey;"><i>Updated May 1, 2013, 6:41 p.m.</i></p>






<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">My previous review (https://git.reviewboard.kde.org/r/109841/) broke \
kurifiltertest.  
The google web shortcut has been changed to use https. This made the kurifilter unit \
test fail some tests. Changed the unit test to check for https.</pre>
  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">All tests pass.</pre>  </td>
 </tr>
</table>




<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>kurifilter-plugins/tests/kurifiltertest.cpp <span style="color: \
grey">(4677a91)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/110259/diff/" style="margin-left: \
3em;">View Diff</a></p>







  </td>
 </tr>
</table>








  </div>
 </body>
</html>



[prev in list] [next in list] [prev in thread] [next in thread]

Configure | About | News | Add a list | Sponsored by KoreLogic