[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Review Request 110271: libusb-1 support in kcmusb (kinfocenter)
From:       "Max Brazhnikov" <makc () freebsd ! org>
Date:       2013-05-02 13:49:58
Message-ID: 20130502134958.7435.37233 () vidsolbach ! de
[Download RAW message or body]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110271/
-----------------------------------------------------------

Review request for kde-workspace.


Description
-------

Use libusb-1 to query info about usb devices in kinfocenter.
Remove *BSD specific code: it doesn't work on all supported FreeBSD versions. In \
principle it can be saved for NetBSD, but NetBSD could use libusb-1, thus drop it for \
simplification. Remove polling and use DeviceNotifier instead.
Add FindLibUSB-1.cmake


Diffs
-----

  cmake/modules/FindLibUSB-1.cmake PRE-CREATION 
  kinfocenter/Modules/usbview/CMakeLists.txt 87bb256 
  kinfocenter/Modules/usbview/config-kcmusb.h.cmake PRE-CREATION 
  kinfocenter/Modules/usbview/kcmusb.cpp c598467 
  kinfocenter/Modules/usbview/usbdevices.h 493caeb 
  kinfocenter/Modules/usbview/usbdevices.cpp 9bd7033 

Diff: http://git.reviewboard.kde.org/r/110271/diff/


Testing
-------

I've tested it only on FreeBSD. It would nice to test at least FindLibUSB-1.cmake on \
other OSes.


Thanks,

Max Brazhnikov


[Attachment #3 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/110271/">http://git.reviewboard.kde.org/r/110271/</a>
  </td>
    </tr>
   </table>
   <br />




<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for kde-workspace.</div>
<div>By Max Brazhnikov.</div>







<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Use libusb-1 to query info about usb devices in kinfocenter. Remove *BSD \
specific code: it doesn&#39;t work on all supported FreeBSD versions. In principle it \
can be saved for NetBSD, but NetBSD could use libusb-1, thus drop it for \
simplification. Remove polling and use DeviceNotifier instead.
Add FindLibUSB-1.cmake
</pre>
  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">I&#39;ve tested it only on FreeBSD. It would nice to test at least \
FindLibUSB-1.cmake on other OSes.</pre>  </td>
 </tr>
</table>




<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>cmake/modules/FindLibUSB-1.cmake <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>kinfocenter/Modules/usbview/CMakeLists.txt <span style="color: \
grey">(87bb256)</span></li>

 <li>kinfocenter/Modules/usbview/config-kcmusb.h.cmake <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>kinfocenter/Modules/usbview/kcmusb.cpp <span style="color: \
grey">(c598467)</span></li>

 <li>kinfocenter/Modules/usbview/usbdevices.h <span style="color: \
grey">(493caeb)</span></li>

 <li>kinfocenter/Modules/usbview/usbdevices.cpp <span style="color: \
grey">(9bd7033)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/110271/diff/" style="margin-left: \
3em;">View Diff</a></p>







  </td>
 </tr>
</table>




  </div>
 </body>
</html>



[prev in list] [next in list] [prev in thread] [next in thread] 

Configure | About | News | Add a list | Sponsored by KoreLogic