[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: Review Request 110138: missing checks for size(0, 0) and missing check before freeing pixmap
From:       Ömer Fadıl Usta <omerusta () gmail ! com>
Date:       2013-04-30 9:04:02
Message-ID: 20130430090402.12968.49633 () vidsolbach ! de
[Download RAW message or body]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110138/
-----------------------------------------------------------

(Updated April 30, 2013, 12:04 p.m.)


Review request for kdelibs, Aaron J. Seigo, Martin Gräßlin, and Marco Martin.


Changes
-------

This is the final (i hope :) ) shape of patch.
Compiled and working fine


Description (updated)
-------

I was getting lots of errors while moving my mouse over system tray before this patch.
Also this patch fixes a forgetten check before freeing a already undefined pixmap


Diffs (updated)
-----

  plasma/private/dialogshadows.cpp 89814ec 

Diff: http://git.reviewboard.kde.org/r/110138/diff/


Testing
-------

Looks like it is working fine


Thanks,

Ömer Fadıl Usta


[Attachment #3 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/110138/">http://git.reviewboard.kde.org/r/110138/</a>
  </td>
    </tr>
   </table>
   <br />




<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for kdelibs, Aaron J. Seigo, Martin Gräßlin, and Marco \
Martin.</div> <div>By Ömer Fadıl Usta.</div>


<p style="color: grey;"><i>Updated April 30, 2013, 12:04 p.m.</i></p>



<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This is the final (i hope :) ) shape of patch. Compiled and working \
fine</pre>  </td>
 </tr>
</table>




<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description  \
(updated)</h1>  <table width="100%" bgcolor="#ffffff" cellspacing="0" \
cellpadding="10" style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">I was getting lots of errors while moving my mouse over system tray \
before this patch. Also this patch fixes a forgetten check before freeing a already \
undefined pixmap </pre>
  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Looks like it is working fine</pre>  </td>
 </tr>
</table>




<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
(updated)</h1> <ul style="margin-left: 3em; padding-left: 0;">

 <li>plasma/private/dialogshadows.cpp <span style="color: grey">(89814ec)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/110138/diff/" style="margin-left: \
3em;">View Diff</a></p>







  </td>
 </tr>
</table>




  </div>
 </body>
</html>



[prev in list] [next in list] [prev in thread] [next in thread]

Configure | About | News | Add a list | Sponsored by KoreLogic