[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-core-devel
Subject: Re: Review Request 110110: Add Musics , Downloads , Videos, Pictures places bookmarks to kfileplaces
From: Thomas_Lübking <thomas.luebking () gmail ! com>
Date: 2013-04-22 7:32:31
Message-ID: 20130422073231.12976.4359 () vidsolbach ! de
[Download RAW message or body]
> On April 21, 2013, 11:33 p.m., Àlex Fiestas wrote:
> > With this patch we would be creating yet another difference between dolphin and \
> > the rest of applications using kfileplacesmodel since dolphin uses Nepomuk while \
> > this patch adds links to folder.
> > Ideally, nepomuk links should be added instead of folders.
is kdelibs open for feature commits again?
if not, i actually don't see how either (links, linking nepomuk) could happen but in \
frameworks... and then i'd rather suggest an approach where dolphin's using kfpm.
- Thomas
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110110/#review31396
-----------------------------------------------------------
On April 21, 2013, 2:54 a.m., Ömer Fadıl Usta wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110110/
> -----------------------------------------------------------
>
> (Updated April 21, 2013, 2:54 a.m.)
>
>
> Review request for kdelibs.
>
>
> Description
> -------
>
> Add Musics , Downloads , Videos, Pictures places bookmarks to kfileplacesmodal
> Patch from Mandriva Linux
>
>
> Diffs
> -----
>
> kfile/kfileplacesmodel.cpp a73274c
>
> Diff: http://git.reviewboard.kde.org/r/110110/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Ömer Fadıl Usta
>
>
[Attachment #3 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/110110/">http://git.reviewboard.kde.org/r/110110/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On April 21st, 2013, 11:33 p.m. UTC, <b>Àlex \
Fiestas</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">With this patch we would be creating yet another difference between \
dolphin and the rest of applications using kfileplacesmodel since dolphin uses \
Nepomuk while this patch adds links to folder.
Ideally, nepomuk links should be added instead of folders.</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">is kdelibs open for \
feature commits again? if not, i actually don't see how either (links, linking \
nepomuk) could happen but in frameworks... and then i'd rather suggest an \
approach where dolphin's using kfpm.</pre> <br />
<p>- Thomas</p>
<br />
<p>On April 21st, 2013, 2:54 a.m. UTC, Ömer Fadıl Usta wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kdelibs.</div>
<div>By Ömer Fadıl Usta.</div>
<p style="color: grey;"><i>Updated April 21, 2013, 2:54 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Add Musics , Downloads , Videos, Pictures places bookmarks to \
kfileplacesmodal Patch from Mandriva Linux</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kfile/kfileplacesmodel.cpp <span style="color: grey">(a73274c)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/110110/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic