[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-core-devel
Subject: Re: Review Request 110118: wrong path for plugin. ( doubling the plugin address cause the basepath t
From: Ömer Fadıl Usta <omerusta () gmail ! com>
Date: 2013-04-21 18:18:50
Message-ID: 20130421181850.20845.68558 () vidsolbach ! de
[Download RAW message or body]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110118/
-----------------------------------------------------------
(Updated April 21, 2013, 9:18 p.m.)
Review request for kde-workspace, Aaron J. Seigo and Marco Martin.
Description
-------
plasma-desktop(7470)/libplasma Plasma::PackageStructure::setPath: \
"/home/usta/kde/inst/master/share/apps/plasma/packages/org.kde.desktop.activitymanager//org.kde.desktop.activitymanager" \
invalid, basePath is ""
it resets basePath due to double pluginname at the end of path.
Diffs
-----
plasma/desktop/shell/activitymanager/activitymanager.cpp 2ecb30d
Diff: http://git.reviewboard.kde.org/r/110118/diff/
Testing
-------
After this patch that warning about invalid path is gone. I have checked that \
package->path() returning correct address now.
Thanks,
Ömer Fadıl Usta
[Attachment #3 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/110118/">http://git.reviewboard.kde.org/r/110118/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kde-workspace, Aaron J. Seigo and Marco Martin.</div>
<div>By Ömer Fadıl Usta.</div>
<p style="color: grey;"><i>Updated April 21, 2013, 9:18 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">plasma-desktop(7470)/libplasma Plasma::PackageStructure::setPath: \
"/home/usta/kde/inst/master/share/apps/plasma/packages/org.kde.desktop.activitymanager//org.kde.desktop.activitymanager" \
invalid, basePath is ""
it resets basePath due to double pluginname at the end of path.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">After this patch that warning about invalid path is gone. I have checked \
that package->path() returning correct address now.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>plasma/desktop/shell/activitymanager/activitymanager.cpp <span style="color: \
grey">(2ecb30d)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/110118/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic