[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-core-devel
Subject: Re: Review Request 110084: Make ftp error messages prettier
From: Thomas_Lübking <thomas.luebking () gmail ! com>
Date: 2013-04-19 16:17:34
Message-ID: 20130419161734.5985.96265 () vidsolbach ! de
[Download RAW message or body]
> On April 19, 2013, 1:13 p.m., David Faure wrote:
> > Well, yes, it looks nicer to my eyes because I'm not very good at german (and \
> > your "before" screenshot is in german) :-P
> > More seriously I'm not sure this will always work... what if the error message is \
> > much longer? Shouldn't it start on its own line so we don't confuse it with the \
> > kio_ftp-provided sentence, in general?
What esp. should not happen is to just print "421" but indicate that this is "Error \
#421" or similar.
More 2 ¢:
For more visual appeal i'd suggest to emphasize the upper (main) line (h2 or maybe \
just b), get rid of the empty line(s? - trailing one) and ideally get the close \
button top aligned (esp. since it almost looks like the icon...)
- Thomas
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110084/#review31289
-----------------------------------------------------------
On April 19, 2013, 1:08 p.m., Kai Uwe Broulik wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110084/
> -----------------------------------------------------------
>
> (Updated April 19, 2013, 1:08 p.m.)
>
>
> Review request for kdelibs and David Faure.
>
>
> Description
> -------
>
> Remove linebreaks and trim the message so the ugly linebreak at the end disappears.
>
>
> This addresses bug 318079.
> http://bugs.kde.org/show_bug.cgi?id=318079
>
>
> Diffs
> -----
>
> kioslave/ftp/ftp.cpp b0868d8
>
> Diff: http://git.reviewboard.kde.org/r/110084/diff/
>
>
> Testing
> -------
>
> Works and looks much nicer :)
>
>
> File Attachments
> ----------------
>
> Before
> http://git.reviewboard.kde.org/media/uploaded/files/2013/04/19/ftpmessagebefore.png
> After
> http://git.reviewboard.kde.org/media/uploaded/files/2013/04/19/ftpmsgafter.png
>
>
> Thanks,
>
> Kai Uwe Broulik
>
>
[Attachment #3 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/110084/">http://git.reviewboard.kde.org/r/110084/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On April 19th, 2013, 1:13 p.m. UTC, <b>David \
Faure</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Well, yes, it looks nicer to my eyes because I'm not very good at \
german (and your "before" screenshot is in german) :-P
More seriously I'm not sure this will always work... what if the error message is \
much longer? Shouldn't it start on its own line so we don't confuse it with \
the kio_ftp-provided sentence, in general?</pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">What esp. should not \
happen is to just print "421" but indicate that this is "Error \
#421" or similar.
More 2 ¢:
For more visual appeal i'd suggest to emphasize the upper (main) line (h2 or \
maybe just b), get rid of the empty line(s? - trailing one) and ideally get the close \
button top aligned (esp. since it almost looks like the icon...)</pre> <br />
<p>- Thomas</p>
<br />
<p>On April 19th, 2013, 1:08 p.m. UTC, Kai Uwe Broulik wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kdelibs and David Faure.</div>
<div>By Kai Uwe Broulik.</div>
<p style="color: grey;"><i>Updated April 19, 2013, 1:08 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Remove linebreaks and trim the message so the ugly linebreak at the end \
disappears.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Works and looks much nicer :)</pre> </td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=318079">318079</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kioslave/ftp/ftp.cpp <span style="color: grey">(b0868d8)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/110084/diff/" style="margin-left: \
3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments \
</h1>
<ul>
<li><a href="http://git.reviewboard.kde.org/media/uploaded/files/2013/04/19/ftpmessagebefore.png">Before</a></li>
<li><a href="http://git.reviewboard.kde.org/media/uploaded/files/2013/04/19/ftpmsgafter.png">After</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic