[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Review Request 110084: Make ftp error messages prettier
From:       "Kai Uwe Broulik" <kde () privat ! broulik ! de>
Date:       2013-04-19 13:08:04
Message-ID: 20130419130804.21660.91656 () vidsolbach ! de
[Download RAW message or body]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110084/
-----------------------------------------------------------

Review request for kdelibs and David Faure.


Description
-------

Remove linebreaks and trim the message so the ugly linebreak at the end disappears.


This addresses bug 318079.
    http://bugs.kde.org/show_bug.cgi?id=318079


Diffs
-----

  kioslave/ftp/ftp.cpp b0868d8 

Diff: http://git.reviewboard.kde.org/r/110084/diff/


Testing
-------

Works and looks much nicer :)


File Attachments
----------------

Before
  http://git.reviewboard.kde.org/media/uploaded/files/2013/04/19/ftpmessagebefore.png
After
  http://git.reviewboard.kde.org/media/uploaded/files/2013/04/19/ftpmsgafter.png


Thanks,

Kai Uwe Broulik


[Attachment #3 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/110084/">http://git.reviewboard.kde.org/r/110084/</a>
  </td>
    </tr>
   </table>
   <br />




<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for kdelibs and David Faure.</div>
<div>By Kai Uwe Broulik.</div>







<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Remove linebreaks and trim the message so the ugly linebreak at the end \
disappears.</pre>  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Works and looks much nicer :)</pre>  </td>
 </tr>
</table>



<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>


 <a href="http://bugs.kde.org/show_bug.cgi?id=318079">318079</a>


</div>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>kioslave/ftp/ftp.cpp <span style="color: grey">(b0868d8)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/110084/diff/" style="margin-left: \
3em;">View Diff</a></p>



<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments \
</h1>

<ul>

 <li><a href="http://git.reviewboard.kde.org/media/uploaded/files/2013/04/19/ftpmessagebefore.png">Before</a></li>


 <li><a href="http://git.reviewboard.kde.org/media/uploaded/files/2013/04/19/ftpmsgafter.png">After</a></li>


</ul>





  </td>
 </tr>
</table>




  </div>
 </body>
</html>



[prev in list] [next in list] [prev in thread] [next in thread]

Configure | About | News | Add a list | Sponsored by KoreLogic