[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-core-devel
Subject: Re: Review Request 109841: Use https for web shortcuts
From: "David Faure" <faure () kde ! org>
Date: 2013-04-19 6:24:34
Message-ID: 20130419062434.10760.47869 () vidsolbach ! de
[Download RAW message or body]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109841/#review31268
-----------------------------------------------------------
Editing translations is pointless, the script that fills them in from .po files \
(called "scripty") will revert all that the night afterwards, and then as translators \
update their translations, the https will slowly come back in. If you want to avoid \
that, you'd have to also update the .po files in i18n - but that's a humongous \
checkout to make.
So I would suggest reducing the patch to just changing the untranslated key, and \
letting the rest happen over time.
- David Faure
On April 3, 2013, 2:59 p.m., Maarten De Meyer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109841/
> -----------------------------------------------------------
>
> (Updated April 3, 2013, 2:59 p.m.)
>
>
> Review request for KDE Runtime.
>
>
> Description
> -------
>
> Use encrypted https for the web shortcuts that support it. Make sure the site does \
> not redirect to unencrypted connection. (exception: google feeling lucky) Other \
> shortcuts need more changes to support SSL. A lot are outdated, I'll post a patch \
> for them soonish.
> This small change should improve protection against networks sniffers.
>
>
> This addresses bug 308029.
> http://bugs.kde.org/show_bug.cgi?id=308029
>
>
> Diffs
> -----
>
> kurifilter-plugins/ikws/searchproviders/blip.desktop b308ad3
> kurifilter-plugins/ikws/searchproviders/facebook.desktop 1ab6de1
> kurifilter-plugins/ikws/searchproviders/flickrcc.desktop 8ab0044
> kurifilter-plugins/ikws/searchproviders/github.desktop 5af6fe6
> kurifilter-plugins/ikws/searchproviders/gitorious.desktop 2a801d9
> kurifilter-plugins/ikws/searchproviders/google.desktop 86fc2e3
> kurifilter-plugins/ikws/searchproviders/google_advanced.desktop 5ec1bba
> kurifilter-plugins/ikws/searchproviders/google_groups.desktop 7366c90
> kurifilter-plugins/ikws/searchproviders/google_lucky.desktop 8b9837f
> kurifilter-plugins/ikws/searchproviders/google_news.desktop 1ef636c
> kurifilter-plugins/ikws/searchproviders/identica_groups.desktop 4d3efe8
> kurifilter-plugins/ikws/searchproviders/identica_notices.desktop 2ed0e5f
> kurifilter-plugins/ikws/searchproviders/identica_people.desktop d233cb8
> kurifilter-plugins/ikws/searchproviders/kde_forums.desktop e7acaaa
> kurifilter-plugins/ikws/searchproviders/wolfram_alpha.desktop 6a8bda6
> kurifilter-plugins/ikws/searchproviders/youtube.desktop 0549216
>
> Diff: http://git.reviewboard.kde.org/r/109841/diff/
>
>
> Testing
> -------
>
> All shortcuts use https and have a valid ssl certificate.
>
>
> Thanks,
>
> Maarten De Meyer
>
>
[Attachment #3 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/109841/">http://git.reviewboard.kde.org/r/109841/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Editing translations is \
pointless, the script that fills them in from .po files (called "scripty") \
will revert all that the night afterwards, and then as translators update their \
translations, the https will slowly come back in. If you want to avoid that, \
you'd have to also update the .po files in i18n - but that's a humongous \
checkout to make.
So I would suggest reducing the patch to just changing the untranslated key, and \
letting the rest happen over time. </pre>
<br />
<p>- David</p>
<br />
<p>On April 3rd, 2013, 2:59 p.m. UTC, Maarten De Meyer wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for KDE Runtime.</div>
<div>By Maarten De Meyer.</div>
<p style="color: grey;"><i>Updated April 3, 2013, 2:59 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Use encrypted https for the web shortcuts that support it. Make sure the \
site does not redirect to unencrypted connection. (exception: google feeling lucky) \
Other shortcuts need more changes to support SSL. A lot are outdated, I'll post a \
patch for them soonish.
This small change should improve protection against networks sniffers.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">All shortcuts use https and have a valid ssl certificate.</pre> </td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=308029">308029</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kurifilter-plugins/ikws/searchproviders/blip.desktop <span style="color: \
grey">(b308ad3)</span></li>
<li>kurifilter-plugins/ikws/searchproviders/facebook.desktop <span style="color: \
grey">(1ab6de1)</span></li>
<li>kurifilter-plugins/ikws/searchproviders/flickrcc.desktop <span style="color: \
grey">(8ab0044)</span></li>
<li>kurifilter-plugins/ikws/searchproviders/github.desktop <span style="color: \
grey">(5af6fe6)</span></li>
<li>kurifilter-plugins/ikws/searchproviders/gitorious.desktop <span style="color: \
grey">(2a801d9)</span></li>
<li>kurifilter-plugins/ikws/searchproviders/google.desktop <span style="color: \
grey">(86fc2e3)</span></li>
<li>kurifilter-plugins/ikws/searchproviders/google_advanced.desktop <span \
style="color: grey">(5ec1bba)</span></li>
<li>kurifilter-plugins/ikws/searchproviders/google_groups.desktop <span \
style="color: grey">(7366c90)</span></li>
<li>kurifilter-plugins/ikws/searchproviders/google_lucky.desktop <span style="color: \
grey">(8b9837f)</span></li>
<li>kurifilter-plugins/ikws/searchproviders/google_news.desktop <span style="color: \
grey">(1ef636c)</span></li>
<li>kurifilter-plugins/ikws/searchproviders/identica_groups.desktop <span \
style="color: grey">(4d3efe8)</span></li>
<li>kurifilter-plugins/ikws/searchproviders/identica_notices.desktop <span \
style="color: grey">(2ed0e5f)</span></li>
<li>kurifilter-plugins/ikws/searchproviders/identica_people.desktop <span \
style="color: grey">(d233cb8)</span></li>
<li>kurifilter-plugins/ikws/searchproviders/kde_forums.desktop <span style="color: \
grey">(e7acaaa)</span></li>
<li>kurifilter-plugins/ikws/searchproviders/wolfram_alpha.desktop <span \
style="color: grey">(6a8bda6)</span></li>
<li>kurifilter-plugins/ikws/searchproviders/youtube.desktop <span style="color: \
grey">(0549216)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/109841/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic