[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-core-devel
Subject: Re: Review Request 110046: Don't format port number in a kio_sftp message
From: Lukáš Tinkl <lukas () kde ! org>
Date: 2013-04-16 17:38:36
Message-ID: 20130416173836.16693.91186 () vidsolbach ! de
[Download RAW message or body]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110046/#review31173
-----------------------------------------------------------
Ship it!
Ship It!
- Lukáš Tinkl
On April 16, 2013, 6:29 p.m., Dan Vrátil wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110046/
> -----------------------------------------------------------
>
> (Updated April 16, 2013, 6:29 p.m.)
>
>
> Review request for KDE Runtime.
>
>
> Description
> -------
>
> Connecting to sftp://user@host.tld:9000 shows "Opening SFTP connection to host \
> host.tld:9,000" when user's locales are using comma to separate thousands.
>
> Diffs
> -----
>
> kioslave/sftp/kio_sftp.cpp f493477
>
> Diff: http://git.reviewboard.kde.org/r/110046/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Dan Vrátil
>
>
[Attachment #3 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/110046/">http://git.reviewboard.kde.org/r/110046/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ship It!</pre> <br />
<p>- Lukáš</p>
<br />
<p>On April 16th, 2013, 6:29 p.m. CEST, Dan Vrátil wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for KDE Runtime.</div>
<div>By Dan Vrátil.</div>
<p style="color: grey;"><i>Updated April 16, 2013, 6:29 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Connecting to sftp://user@host.tld:9000 shows "Opening SFTP \
connection to host host.tld:9,000" when user's locales are using comma to \
separate thousands.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kioslave/sftp/kio_sftp.cpp <span style="color: grey">(f493477)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/110046/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic