[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Review Request 109844: Fixes a Null pointer problem and increase readability
From:       Ömer Fadıl Usta <omerusta () gmail ! com>
Date:       2013-04-03 16:22:39
Message-ID: 20130403162239.2414.8725 () vidsolbach ! de
[Download RAW message or body]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109844/
-----------------------------------------------------------

Review request for kde-workspace.


Description
-------

I have faced a "TaskManager::AlphaSortingStrategy::sortItems: Null Pointer" error in \
my .xsession_errors file and when i  check cpp i have saw that :  TaskItem *item = \
qobject_cast<TaskItem*>(groupable); on the other hand all checkings for qroupable \
variable are in other if clauses which are not satisfy all situations.


Diffs
-----

  libs/taskmanager/strategies/alphasortingstrategy.cpp d4dda00 

Diff: http://git.reviewboard.kde.org/r/109844/diff/


Testing
-------


Thanks,

Ömer Fadıl Usta


[Attachment #3 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/109844/">http://git.reviewboard.kde.org/r/109844/</a>
  </td>
    </tr>
   </table>
   <br />




<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for kde-workspace.</div>
<div>By Ömer Fadıl Usta.</div>







<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">I have faced a &quot;TaskManager::AlphaSortingStrategy::sortItems: Null \
Pointer&quot; error in my .xsession_errors file and when i  check cpp i have saw that \
:  TaskItem *item = qobject_cast&lt;TaskItem*&gt;(groupable);
on the other hand all checkings for qroupable variable are in other if clauses which \
are not satisfy all situations.</pre>  </td>
 </tr>
</table>





<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>libs/taskmanager/strategies/alphasortingstrategy.cpp <span style="color: \
grey">(d4dda00)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/109844/diff/" style="margin-left: \
3em;">View Diff</a></p>







  </td>
 </tr>
</table>




  </div>
 </body>
</html>



[prev in list] [next in list] [prev in thread] [next in thread]

Configure | About | News | Add a list | Sponsored by KoreLogic