[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-core-devel
Subject: Re: Review Request 108929: khtml/kjs: Implement typed-arrays
From: "Bernd Buschinski" <b.buschinski () googlemail ! com>
Date: 2013-02-19 0:03:15
Message-ID: 20130219000315.11135.70480 () vidsolbach ! de
[Download RAW message or body]
> On Feb. 13, 2013, 9:13 a.m., Andrea Iacovitti wrote:
> > khtml/ecma/kjs_arraybufferview.h, line 29
> > <http://git.reviewboard.kde.org/r/108929/diff/2/?file=113855#file113855line29>
> >
> > Is this include really necessary or just an accident? (Noticed because a \
> > compilation error)
>
> Bernd Buschinski wrote:
> ha, good catch, no clue how this sneaked in
>
> Milian Wolff wrote:
> Do you use KDevelop? ;-) Second report I hear today of accidental includes sneaking \
> in...
Heh, yes kdevelop :)
- Bernd
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108929/#review27353
-----------------------------------------------------------
On Feb. 19, 2013, 12:03 a.m., Bernd Buschinski wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108929/
> -----------------------------------------------------------
>
> (Updated Feb. 19, 2013, 12:03 a.m.)
>
>
> Review request for kdelibs.
>
>
> Description
> -------
>
> khtml/kjs: Implement typed-arrays
>
> ArrayBuffer, Int8Array, Uint8Array, Int16Array, Uint16Array, Int32Array, \
> Uint32Array, Float32Array, Float64Array
> I tested many configuration under valgrind, to find all possible errors.
> It seems other browsers don't set a limit, so you can eat all memory with these \
> arrays (danger), so khtml/kjs also doesn't set a limit. If you feel like we really \
> need one, please tell.
>
> Diffs
> -----
>
> khtml/ecma/kjs_window.cpp 927d251
> khtml/ecma/kjs_window.h 1b70be1
> khtml/ecma/kjs_arraybufferview.h PRE-CREATION
> khtml/ecma/kjs_arraybufferview.cpp PRE-CREATION
> khtml/ecma/kjs_arraybuffer.cpp PRE-CREATION
> khtml/CMakeLists.txt 99034cc
> khtml/ecma/kjs_arraybuffer.h PRE-CREATION
>
> Diff: http://git.reviewboard.kde.org/r/108929/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Bernd Buschinski
>
>
[Attachment #3 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/108929/">http://git.reviewboard.kde.org/r/108929/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On February 13th, 2013, 9:13 a.m. UTC, <b>Andrea \
Iacovitti</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/108929/diff/2/?file=113855#file113855line29" \
style="color: black; font-weight: bold; text-decoration: \
underline;">khtml/ecma/kjs_arraybufferview.h</a> <span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">29</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="cp">#include <tiff.h></span></pre></td> </tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Is this include really \
necessary or just an accident? (Noticed because a compilation error)</pre> \
</blockquote>
<p>On February 13th, 2013, 1:39 p.m. UTC, <b>Bernd Buschinski</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">ha, good catch, no clue \
how this sneaked in</pre> </blockquote>
<p>On February 14th, 2013, 3:07 p.m. UTC, <b>Milian Wolff</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Do you use KDevelop? ;-) \
Second report I hear today of accidental includes sneaking in...</pre> </blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Heh, yes \
kdevelop :)</pre> <br />
<p>- Bernd</p>
<br />
<p>On February 19th, 2013, 12:03 a.m. UTC, Bernd Buschinski wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kdelibs.</div>
<div>By Bernd Buschinski.</div>
<p style="color: grey;"><i>Updated Feb. 19, 2013, 12:03 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">khtml/kjs: Implement typed-arrays
ArrayBuffer, Int8Array, Uint8Array, Int16Array, Uint16Array, Int32Array, Uint32Array, \
Float32Array, Float64Array
I tested many configuration under valgrind, to find all possible errors.
It seems other browsers don't set a limit, so you can eat all memory with these \
arrays (danger), so khtml/kjs also doesn't set a limit. If you feel like we \
really need one, please tell.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>khtml/ecma/kjs_window.cpp <span style="color: grey">(927d251)</span></li>
<li>khtml/ecma/kjs_window.h <span style="color: grey">(1b70be1)</span></li>
<li>khtml/ecma/kjs_arraybufferview.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>khtml/ecma/kjs_arraybufferview.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>khtml/ecma/kjs_arraybuffer.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>khtml/CMakeLists.txt <span style="color: grey">(99034cc)</span></li>
<li>khtml/ecma/kjs_arraybuffer.h <span style="color: \
grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/108929/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic