[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-core-devel
Subject: Re: Review Request 108929: khtml/kjs: Implement typed-arrays
From: "Rolf Eike Beer" <kde () opensource ! sf-tec ! de>
Date: 2013-02-16 17:37:28
Message-ID: 20130216173728.19057.81156 () vidsolbach ! de
[Download RAW message or body]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108929/#review27549
-----------------------------------------------------------
khtml/ecma/kjs_arraybuffer.cpp
<http://git.reviewboard.kde.org/r/108929/#comment20674>
Those can be size_t, you check that the passed value is > 0 before assignment \
anyway.
khtml/ecma/kjs_arraybuffer.cpp
<http://git.reviewboard.kde.org/r/108929/#comment20675>
This doesn't need to be ssize_t either, you also check for is being always \
positive. This allows to get rid of the cast in the second if.
khtml/ecma/kjs_arraybufferview.h
<http://git.reviewboard.kde.org/r/108929/#comment20676>
Can be size_t, for the same reason as above.
khtml/ecma/kjs_arraybufferview.h
<http://git.reviewboard.kde.org/r/108929/#comment20677>
should be static_cast<size_t>, the result is of type size_t.
khtml/ecma/kjs_arraybufferview.h
<http://git.reviewboard.kde.org/r/108929/#comment20678>
Is it guaranteed that this doesn't wraparound? That would be one of the few cases \
where ssize_t may actually be needed.
khtml/ecma/kjs_arraybufferview.h
<http://git.reviewboard.kde.org/r/108929/#comment20679>
size_t
- Rolf Eike Beer
On Feb. 13, 2013, 8:18 p.m., Bernd Buschinski wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108929/
> -----------------------------------------------------------
>
> (Updated Feb. 13, 2013, 8:18 p.m.)
>
>
> Review request for kdelibs.
>
>
> Description
> -------
>
> khtml/kjs: Implement typed-arrays
>
> ArrayBuffer, Int8Array, Uint8Array, Int16Array, Uint16Array, Int32Array, \
> Uint32Array, Float32Array, Float64Array
> I tested many configuration under valgrind, to find all possible errors.
> It seems other browsers don't set a limit, so you can eat all memory with these \
> arrays (danger), so khtml/kjs also doesn't set a limit. If you feel like we really \
> need one, please tell.
>
> Diffs
> -----
>
> khtml/CMakeLists.txt 99034cc
> khtml/ecma/kjs_arraybuffer.h PRE-CREATION
> khtml/ecma/kjs_arraybuffer.cpp PRE-CREATION
> khtml/ecma/kjs_arraybufferview.h PRE-CREATION
> khtml/ecma/kjs_arraybufferview.cpp PRE-CREATION
> khtml/ecma/kjs_window.h 1b70be1
> khtml/ecma/kjs_window.cpp 927d251
>
> Diff: http://git.reviewboard.kde.org/r/108929/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Bernd Buschinski
>
>
[Attachment #3 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/108929/">http://git.reviewboard.kde.org/r/108929/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/108929/diff/4/?file=113953#file113953line132" \
style="color: black; font-weight: bold; text-decoration: \
underline;">khtml/ecma/kjs_arraybuffer.cpp</a> <span style="font-weight: normal;">
(Diff revision 4)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">132</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> \
<span class="kt">ssize_t</span> <span class="n">start</span> <span class="o">=</span> \
<span class="mi">0</span><span class="p">;</span></pre></td> </tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">133</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> \
<span class="kt">ssize_t</span> <span class="n">end</span> <span class="o">=</span> \
<span class="mi">0</span><span class="p">;</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Those can \
be size_t, you check that the passed value is > 0 before assignment anyway.</pre> \
</div> <br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/108929/diff/4/?file=113953#file113953line141" \
style="color: black; font-weight: bold; text-decoration: \
underline;">khtml/ecma/kjs_arraybuffer.cpp</a> <span style="font-weight: normal;">
(Diff revision 4)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">141</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> \
<span class="kt">ssize_t</span> <span class="n">length</span> <span \
class="o">=</span> <span class="n">end</span> <span class="o">-</span> <span \
class="n">start</span><span class="p">;</span></pre></td> </tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">142</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> \
<span class="k">if</span> <span class="p">(</span><span class="n">end</span> <span \
class="o"><</span> <span class="n">start</span><span class="p">)</span></pre></td> \
</tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">143</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> \
<span class="n">length</span> <span class="o">=</span> <span \
class="n">arraybuf</span><span class="o">-></span><span \
class="n">byteLength</span><span class="p">();</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This \
doesn't need to be ssize_t either, you also check for is being always positive. \
This allows to get rid of the cast in the second if.</pre> </div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/108929/diff/4/?file=113954#file113954line174" \
style="color: black; font-weight: bold; text-decoration: \
underline;">khtml/ecma/kjs_arraybufferview.h</a> <span style="font-weight: normal;">
(Diff revision 4)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">174</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> \
<span class="kt">ssize_t</span> <span class="n">begin</span> <span class="o">=</span> \
<span class="mi">0</span><span class="p">;</span></pre></td> </tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">175</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> \
<span class="kt">ssize_t</span> <span class="n">end</span> <span class="o">=</span> \
<span class="mi">0</span><span class="p">;</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Can be \
size_t, for the same reason as above.</pre> </div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/108929/diff/4/?file=113954#file113954line198" \
style="color: black; font-weight: bold; text-decoration: \
underline;">khtml/ecma/kjs_arraybufferview.h</a> <span style="font-weight: normal;">
(Diff revision 4)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">198</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> \
<span class="n">offset</span> <span class="o">=</span> <span \
class="n">static_cast</span><span class="o"><</span><span \
class="kt">ssize_t</span><span class="o">></span><span class="p">(</span><span \
class="n">tmp</span><span class="p">)</span> <span class="o">*</span> <span \
class="k">sizeof</span><span class="p">(</span><span class="n">T</span><span \
class="p">);</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">should be \
static_cast<size_t>, the result is of type size_t.</pre> </div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/108929/diff/4/?file=113954#file113954line200" \
style="color: black; font-weight: bold; text-decoration: \
underline;">khtml/ecma/kjs_arraybufferview.h</a> <span style="font-weight: normal;">
(Diff revision 4)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">200</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> \
<span class="k">if</span> <span class="p">(</span><span class="n">other</span><span \
class="o">-></span><span class="n">byteLength</span><span class="p">()</span> \
<span class="o">-</span> <span class="n">offset</span> <span class="o">></span> \
<span class="n">view</span><span class="o">-></span><span \
class="n">byteLength</span><span class="p">())</span> <span \
class="p">{</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Is it \
guaranteed that this doesn't wraparound? That would be one of the few cases where \
ssize_t may actually be needed.</pre> </div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/108929/diff/4/?file=113954#file113954line287" \
style="color: black; font-weight: bold; text-decoration: \
underline;">khtml/ecma/kjs_arraybufferview.h</a> <span style="font-weight: normal;">
(Diff revision 4)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">287</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> \
<span class="kt">ssize_t</span> <span class="n">length</span> <span \
class="o">=</span> <span class="mi">0</span><span class="p">;</span></pre></td> \
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">size_t</pre> </div>
<br />
<p>- Rolf Eike</p>
<br />
<p>On February 13th, 2013, 8:18 p.m. UTC, Bernd Buschinski wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kdelibs.</div>
<div>By Bernd Buschinski.</div>
<p style="color: grey;"><i>Updated Feb. 13, 2013, 8:18 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">khtml/kjs: Implement typed-arrays
ArrayBuffer, Int8Array, Uint8Array, Int16Array, Uint16Array, Int32Array, Uint32Array, \
Float32Array, Float64Array
I tested many configuration under valgrind, to find all possible errors.
It seems other browsers don't set a limit, so you can eat all memory with these \
arrays (danger), so khtml/kjs also doesn't set a limit. If you feel like we \
really need one, please tell.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>khtml/CMakeLists.txt <span style="color: grey">(99034cc)</span></li>
<li>khtml/ecma/kjs_arraybuffer.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>khtml/ecma/kjs_arraybuffer.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>khtml/ecma/kjs_arraybufferview.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>khtml/ecma/kjs_arraybufferview.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>khtml/ecma/kjs_window.h <span style="color: grey">(1b70be1)</span></li>
<li>khtml/ecma/kjs_window.cpp <span style="color: grey">(927d251)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/108929/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic