[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: Review Request 108731: khtml/canvas: Use extra bool to check if PainterPath is empty
From:       "Bernd Buschinski" <b.buschinski () googlemail ! com>
Date:       2013-02-04 0:02:40
Message-ID: 20130204000240.17886.40946 () vidsolbach ! de
[Download RAW message or body]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108731/
-----------------------------------------------------------

(Updated Feb. 4, 2013, 12:02 a.m.)


Review request for kdelibs.


Changes
-------

Don't mark Path as empty on closeSubpath call.
Qt doc confussed me, but it does the right thing.


Description
-------

khtml/canvas: Use extra bool to check if PainterPath is empty,
storring a Inf/Inf member no longer work with recent Qt versions and
storring NaN/NaN never worked, Qt just ignores storring them.

And set Starting point in arcTo if Path is empty, according to:
http://philip.html5.org/tests/canvas/suite/tests/spec.html#testrefs.2d.path.arcTo.empty
http://philip.html5.org/tests/canvas/suite/tests/spec.html#ensure-there-is-a-subpath
and test:
http://philip.html5.org/tests/canvas/suite/tests/2d.path.arcTo.ensuresubpath.1.html


Diffs (updated)
-----

  khtml/html/html_canvasimpl.h f31954f 
  khtml/html/html_canvasimpl.cpp 93d5db7 

Diff: http://git.reviewboard.kde.org/r/108731/diff/


Testing
-------


Thanks,

Bernd Buschinski


[Attachment #3 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/108731/">http://git.reviewboard.kde.org/r/108731/</a>
  </td>
    </tr>
   </table>
   <br />




<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for kdelibs.</div>
<div>By Bernd Buschinski.</div>


<p style="color: grey;"><i>Updated Feb. 4, 2013, 12:02 a.m.</i></p>



<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Don&#39;t mark Path as empty on closeSubpath call. Qt doc confussed me, \
but it does the right thing.</pre>  </td>
 </tr>
</table>




<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">khtml/canvas: Use extra bool to check if PainterPath is empty, storring \
a Inf/Inf member no longer work with recent Qt versions and storring NaN/NaN never \
worked, Qt just ignores storring them.

And set Starting point in arcTo if Path is empty, according to:
http://philip.html5.org/tests/canvas/suite/tests/spec.html#testrefs.2d.path.arcTo.empty
 http://philip.html5.org/tests/canvas/suite/tests/spec.html#ensure-there-is-a-subpath
and test:
http://philip.html5.org/tests/canvas/suite/tests/2d.path.arcTo.ensuresubpath.1.html</pre>
  </td>
 </tr>
</table>





<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
(updated)</h1> <ul style="margin-left: 3em; padding-left: 0;">

 <li>khtml/html/html_canvasimpl.h <span style="color: grey">(f31954f)</span></li>

 <li>khtml/html/html_canvasimpl.cpp <span style="color: grey">(93d5db7)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/108731/diff/" style="margin-left: \
3em;">View Diff</a></p>







  </td>
 </tr>
</table>




  </div>
 </body>
</html>



[prev in list] [next in list] [prev in thread] [next in thread]

Configure | About | News | Add a list | Sponsored by KoreLogic