[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-core-devel
Subject: Review Request 108727: ktimezoned: Watch /etc/localtime if it doesn't exist yet.
From: "Kevin Kofler" <kevin.kofler () chello ! at>
Date: 2013-02-03 4:30:14
Message-ID: 20130203043014.21443.82201 () vidsolbach ! de
[Download RAW message or body]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108727/
-----------------------------------------------------------
Review request for KDE Runtime and David Jarvie.
Description
-------
/etc/localtime legitimately might not exist. The default is then UTC. But the file \
can then be created later, so watch for its creation.
If we don't do this, when setting the time zone for the first time using kcm_clock, \
the initially set time zone will fail to get reloaded and the dialog will \
unexpectedly jump back to UTC.
This problem shows up on Fedora 18, see:
https://bugzilla.redhat.com/show_bug.cgi?id=906972
Please note that to test the fix with kcm_clock, you also need the kcm_clock \
(kde-workspace) fix from: https://git.reviewboard.kde.org/r/108711/
(which is already approved and which I'll push to KDE/4.10 and merge to master as \
soon as the 4.10.0 tagging freeze is lifted).
Diffs
-----
ktimezoned/ktimezoned.cpp 4eafa4e
Diff: http://git.reviewboard.kde.org/r/108727/diff/
Testing
-------
Builds against at least 4.10.0 and 4.9.5.
Works at runtime (and appears to fix the bug): \
https://bugzilla.redhat.com/show_bug.cgi?id=906972#c5
Thanks,
Kevin Kofler
[Attachment #3 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/108727/">http://git.reviewboard.kde.org/r/108727/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for KDE Runtime and David Jarvie.</div>
<div>By Kevin Kofler.</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">/etc/localtime legitimately might not exist. The default is then UTC. \
But the file can then be created later, so watch for its creation.
If we don't do this, when setting the time zone for the first time using \
kcm_clock, the initially set time zone will fail to get reloaded and the dialog will \
unexpectedly jump back to UTC.
This problem shows up on Fedora 18, see:
https://bugzilla.redhat.com/show_bug.cgi?id=906972
Please note that to test the fix with kcm_clock, you also need the kcm_clock \
(kde-workspace) fix from: https://git.reviewboard.kde.org/r/108711/
(which is already approved and which I'll push to KDE/4.10 and merge to master as \
soon as the 4.10.0 tagging freeze is lifted).</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Builds against at least 4.10.0 and 4.9.5.
Works at runtime (and appears to fix the bug): \
https://bugzilla.redhat.com/show_bug.cgi?id=906972#c5</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>ktimezoned/ktimezoned.cpp <span style="color: grey">(4eafa4e)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/108727/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic