[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-core-devel
Subject: Re: Review Request 108570: This patch add support for bulk operations in systemtray applet settings.
From: "Sandro Andrade" <sandroandrade () kde ! org>
Date: 2013-01-25 19:09:35
Message-ID: 20130125190935.31785.58305 () vidsolbach ! de
[Download RAW message or body]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108570/
-----------------------------------------------------------
(Updated Jan. 25, 2013, 4:09 p.m.)
Review request for kde-workspace.
Changes
-------
Patch updated. Link to demo video: http://wiki.ifba.edu.br/systraybulkop.ogv
Bulk operations are shown only when some item(s) is(are) selected.
It's up to you to decide if we keep the clear shortcut icon :)
If removing it we might remove the whole bulk operation table and then use a
single QLabel+KComboBox (probably not getting aligned to item's KComboBox anymore).
Description
-------
In page 'entries', user can select/deselect a specific or all entries and then change \
visibility and/or reset shortcut for all of them with a single combo selection/clear \
button click. Individually selecting all entries causes header's checkbox to \
automatically be checked. After selecting all entries (individually or by clicking in \
header's checkbox), a single entry deselection causes header's checkbox to \
automatically be unchecked. General suggestions and, in particular about UI \
usability, are appreciated.
Diffs (updated)
-----
plasma/generic/applets/systemtray/ui/autohide.ui 3b6efff
plasma/generic/applets/systemtray/ui/applet.h 0b4a869
plasma/generic/applets/systemtray/ui/applet.cpp 09482d7
Diff: http://git.reviewboard.kde.org/r/108570/diff/
Testing
-------
File Attachments
----------------
Initial setup
http://git.reviewboard.kde.org/media/uploaded/files/2013/01/24/systemtray-bulkactions1.png
Setting all visibilities to 'Auto'
http://git.reviewboard.kde.org/media/uploaded/files/2013/01/24/systemtray-bulkactions2.png
All visibilities adjusted to 'Auto'
http://git.reviewboard.kde.org/media/uploaded/files/2013/01/24/systemtray-bulkactions3.png
Setting two specific item visibilities to 'Always Visible'
http://git.reviewboard.kde.org/media/uploaded/files/2013/01/24/systemtray-bulkactions4.png
Thanks,
Sandro Andrade
[Attachment #3 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/108570/">http://git.reviewboard.kde.org/r/108570/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kde-workspace.</div>
<div>By Sandro Andrade.</div>
<p style="color: grey;"><i>Updated Jan. 25, 2013, 4:09 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Patch updated. Link to demo video: \
http://wiki.ifba.edu.br/systraybulkop.ogv Bulk operations are shown only when some \
item(s) is(are) selected. It's up to you to decide if we keep the clear shortcut \
icon :) If removing it we might remove the whole bulk operation table and then use a
single QLabel+KComboBox (probably not getting aligned to item's KComboBox \
anymore).</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">In page 'entries', user can select/deselect a specific or all \
entries and then change visibility and/or reset shortcut for all of them with a \
single combo selection/clear button click. Individually selecting all entries causes \
header's checkbox to automatically be checked. After selecting all entries \
(individually or by clicking in header's checkbox), a single entry deselection \
causes header's checkbox to automatically be unchecked. General suggestions and, \
in particular about UI usability, are appreciated.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
(updated)</h1> <ul style="margin-left: 3em; padding-left: 0;">
<li>plasma/generic/applets/systemtray/ui/autohide.ui <span style="color: \
grey">(3b6efff)</span></li>
<li>plasma/generic/applets/systemtray/ui/applet.h <span style="color: \
grey">(0b4a869)</span></li>
<li>plasma/generic/applets/systemtray/ui/applet.cpp <span style="color: \
grey">(09482d7)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/108570/diff/" style="margin-left: \
3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments \
</h1>
<ul>
<li><a href="http://git.reviewboard.kde.org/media/uploaded/files/2013/01/24/systemtray-bulkactions1.png">Initial \
setup</a></li>
<li><a href="http://git.reviewboard.kde.org/media/uploaded/files/2013/01/24/systemtray-bulkactions2.png">Setting \
all visibilities to 'Auto'</a></li>
<li><a href="http://git.reviewboard.kde.org/media/uploaded/files/2013/01/24/systemtray-bulkactions3.png">All \
visibilities adjusted to 'Auto'</a></li>
<li><a href="http://git.reviewboard.kde.org/media/uploaded/files/2013/01/24/systemtray-bulkactions4.png">Setting \
two specific item visibilities to 'Always Visible'</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic