'Review Request 108560: Fix kconfigcompiler_test'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Review Request 108560: Fix kconfigcompiler_test
From:       "Alexander Richardson" <arichardson.kde () googlemail ! com>
Date:       2013-01-22 21:45:14
Message-ID: 20130122214514.10032.68809 () vidsolbach ! de
[Download RAW message or body]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108560/
-----------------------------------------------------------

Review request for kdelibs.


Summary (updated)
-----------------

Fix kconfigcompiler_test


Description (updated)
-------

Fix kconfigcompiler_test

It previously did not find the required files since CMake set TESTSRCDIR
wrongly. It was surrounded by quotes and lacking a trailing /

This did not cause test failures since QCOMPARE/QVERIFY was not used
directly in the test function, so it simply printed messages instead.


Diffs (updated)
-----

  tier2/kconfig/autotests/kconfig_compiler/CMakeLists.txt \
846476a6370ad41b1fbc808e2c738c85042e59a3   \
tier2/kconfig/autotests/kconfig_compiler/kconfigcompiler_test.h \
1be213f5036c03a3ef9347005d5d53e6b440a4d4   \
tier2/kconfig/autotests/kconfig_compiler/kconfigcompiler_test.cpp \
f900aaf53de1996213c27357fee5b436ab3c4c8f 

Diff: http://git.reviewboard.kde.org/r/108560/diff/


Testing (updated)
-------

Unit test now passes instead of printing messages and failing silently


Thanks,

Alexander Richardson


[Attachment #3 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/108560/">http://git.reviewboard.kde.org/r/108560/</a>
  </td>
    </tr>
   </table>
   <br />


<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for kdelibs.</div>
<div>By Alexander Richardson.</div>






<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Summary \
(updated)</h1> <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Fix kconfigcompiler_test</pre>  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description  \
(updated)</h1>  <table width="100%" bgcolor="#ffffff" cellspacing="0" \
cellpadding="10" style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Fix kconfigcompiler_test

It previously did not find the required files since CMake set TESTSRCDIR
wrongly. It was surrounded by quotes and lacking a trailing /

This did not cause test failures since QCOMPARE/QVERIFY was not used
directly in the test function, so it simply printed messages instead.</pre>
  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing \
(updated)</h1> <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Unit test now passes instead of printing messages and failing \
silently</pre>  </td>
 </tr>
</table>




<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
(updated)</h1> <ul style="margin-left: 3em; padding-left: 0;">

 <li>tier2/kconfig/autotests/kconfig_compiler/CMakeLists.txt <span style="color: \
grey">(846476a6370ad41b1fbc808e2c738c85042e59a3)</span></li>

 <li>tier2/kconfig/autotests/kconfig_compiler/kconfigcompiler_test.h <span \
style="color: grey">(1be213f5036c03a3ef9347005d5d53e6b440a4d4)</span></li>

 <li>tier2/kconfig/autotests/kconfig_compiler/kconfigcompiler_test.cpp <span \
style="color: grey">(f900aaf53de1996213c27357fee5b436ab3c4c8f)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/108560/diff/" style="margin-left: \
3em;">View Diff</a></p>







  </td>
 </tr>
</table>




  </div>
 </body>
</html>



[prev in list] [next in list] [prev in thread] [next in thread]
Configure | About | News | Add a list | Sponsored by KoreLogic