[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-core-devel
Subject: Review Request 108541: KBugReport should open enter_bug.cgi directly instead of wizard.cgi on bugs.k
From: "Jekyll Wu" <adaptee () gmail ! com>
Date: 2013-01-22 11:09:26
Message-ID: 20130122110926.9771.97424 () vidsolbach ! de
[Download RAW message or body]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108541/
-----------------------------------------------------------
Review request for kdelibs and Ben Cooksley.
Description
-------
Currently kbugreport just can't fill platform information. There are two reasons:
1. kbugreport currently pass the results of uname, while bugs.kde.org expects a few
predefined values like "Gentoo packages", "Chakra", "Ubuntu packages", etc.
2. even if kbugreport passes those expected values, wizard.cgi in its current form \
doesn't correctly redirect those info to enter_bugs.cgi, since the latter expects and \
understands "sys_os" and "rep_platform" fields, instead of the "additional_info" \
field.
According to this commit[1], the home-made wizard.cgi exists solely for the sake \
of compatibility. So I wouldn't expect any one has the motivation to improve \
wizard.cgi.
This patch makes kbugreport interact with enter_bug.cgi directly. It doesn't really \
improve anything, but it comes as preparation for further work. There is no \
functionality lost, since the feature of filling platform information has been broken \
for a long time.
Side note: As written in the TODO, I would like to make kbugreport correctly fill OS \
and Platform information. The plan is stupid, just reuse/copy the \
systeminformation.cpp[2] from drkonqi, which does a good job in guessing OS and \
Platform for drkonqi. But I don't know whether such code duplication is allowed or \
will interfere with the frameworks .
[1] http://commits.kde.org/websites/bugs-kde-org/491ded267e43faa79723fd31a9b64dd266a6f932
[2] https://projects.kde.org/projects/kde/kde-runtime/repository/revisions/master/entry/drkonqi/systeminformation.cpp
This addresses bug 291346.
http://bugs.kde.org/show_bug.cgi?id=291346
Diffs
-----
kdeui/dialogs/kbugreport.cpp 2e72828
Diff: http://git.reviewboard.kde.org/r/108541/diff/
Testing
-------
Thanks,
Jekyll Wu
[Attachment #3 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/108541/">http://git.reviewboard.kde.org/r/108541/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kdelibs and Ben Cooksley.</div>
<div>By Jekyll Wu.</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Currently kbugreport just can't fill platform information. There are \
two reasons:
1. kbugreport currently pass the results of uname, while bugs.kde.org expects a few
predefined values like "Gentoo packages", "Chakra", "Ubuntu \
packages", etc.
2. even if kbugreport passes those expected values, wizard.cgi in its current form \
doesn't correctly redirect those info to enter_bugs.cgi, since the latter expects \
and understands "sys_os" and "rep_platform" fields, instead of \
the "additional_info" field.
According to this commit[1], the home-made wizard.cgi exists solely for the sake \
of compatibility. So I wouldn't expect any one has the motivation to improve \
wizard.cgi.
This patch makes kbugreport interact with enter_bug.cgi directly. It doesn't \
really improve anything, but it comes as preparation for further work. There is no \
functionality lost, since the feature of filling platform information has been broken \
for a long time.
Side note: As written in the TODO, I would like to make kbugreport correctly fill OS \
and Platform information. The plan is stupid, just reuse/copy the \
systeminformation.cpp[2] from drkonqi, which does a good job in guessing OS and \
Platform for drkonqi. But I don't know whether such code duplication is allowed \
or will interfere with the frameworks .
[1] http://commits.kde.org/websites/bugs-kde-org/491ded267e43faa79723fd31a9b64dd266a6f932
[2] https://projects.kde.org/projects/kde/kde-runtime/repository/revisions/master/entry/drkonqi/systeminformation.cpp
</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=291346">291346</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kdeui/dialogs/kbugreport.cpp <span style="color: grey">(2e72828)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/108541/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic