[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-core-devel
Subject: Re: Review Request 108237: [Bug 286768] Duplicate entries in KWallet default wallet comboBox
From: "Maciej Sitarz" <macieksitarz () wp ! pl>
Date: 2013-01-21 22:33:19
Message-ID: 20130121223319.1798.26223 () vidsolbach ! de
[Download RAW message or body]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108237/
-----------------------------------------------------------
(Updated Jan. 21, 2013, 10:33 p.m.)
Review request for kdelibs.
Description
-------
Fix for Bug 286768
This patch fixes duplicate entries in "Default wallet" combobox.
"Local Wallet" combobox could be also wrong as it used currentIndex of "Default Wallet" combobox
Diffs
-----
konfigurator/konfigurator.cpp 3cc1b3f08feb0feb1aa70028508ce5041fefd9f3
Diff: http://git.reviewboard.kde.org/r/108237/diff/
Testing
-------
Tested on Archlinux and KDE 4.9.5
Thanks,
Maciej Sitarz
[Attachment #3 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/108237/">http://git.reviewboard.kde.org/r/108237/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kdelibs.</div>
<div>By Maciej Sitarz.</div>
<p style="color: grey;"><i>Updated Jan. 21, 2013, 10:33 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Fix for Bug 286768 This patch fixes duplicate entries in "Default \
wallet" combobox.
"Local Wallet" combobox could be also wrong as it used currentIndex of \
"Default Wallet" combobox </pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Tested on Archlinux and KDE 4.9.5</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>konfigurator/konfigurator.cpp <span style="color: \
grey">(3cc1b3f08feb0feb1aa70028508ce5041fefd9f3)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/108237/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic