From kde-core-devel Fri Jan 11 11:53:27 2013 From: "Lamarque V. Souza" Date: Fri, 11 Jan 2013 11:53:27 +0000 To: kde-core-devel Subject: Re: New lockscreen Message-Id: <201301110953.27201.lamarque () kde ! org> X-MARC-Message: https://marc.info/?l=kde-core-devel&m=135790523111554 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--Boundary-01=_30/7QLGEC/nLdtX" --Boundary-01=_30/7QLGEC/nLdtX Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Em Friday 11 January 2013, Martin Sandsmark escreveu: > On Fri, Jan 11, 2013 at 10:32:38AM +0100, Marco Martin wrote: > > 311188 since i don't have a a multiscreen setup at the moment > > Me neither, unfortunately. :( > > > difference between 312427 and 311033 (but then he confirmed that he had > > xscreensaver enabled as well so they're actually duplicates) > > Thanks for fixing it. :D > > > in 311116 here works in the case a screensaver is enabled (ie esc shows > > the screensaver again) > > Yes, I tested this briefly yesterday, and it seemed to work, but not > always. I'll test more when I get home again. > > > this i can reproduce, i don't know much yet how to fix: > > 310611 (accelerators) > > The code from Elias won't work? Actually, that code belongs to basysKom (I mean the copyright) and I wrote it for them when I worked in basysKom's Contour project. Anyway, after some time researching I came to the conclusion that QML does not implement the concept of accelerators, so I had to emulate it in the QML shutdown dialog. The problem with that implementation is how to list all buttons in a given window and only on that window so buttons in different windows but with the same accel key are not triggered at the same time. In QML shutdown dialog the list is hardcoded so this was not a big deal, to implement something similar in Plasma Components we need something better. -- Lamarque V. Souza KDE's Network Management maintainer http://planetkde.org/pt-br --Boundary-01=_30/7QLGEC/nLdtX Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: 7bit

Em Friday 11 January 2013, Martin Sandsmark escreveu:

> On Fri, Jan 11, 2013 at 10:32:38AM +0100, Marco Martin wrote:

> > 311188 since i don't have a a multiscreen setup at the moment

> Me neither, unfortunately. :(

> > difference between 312427 and 311033 (but then he confirmed that he had

> > xscreensaver enabled as well so they're actually duplicates)

> Thanks for fixing it. :D

> > in 311116 here works in the case a screensaver is enabled (ie esc shows

> > the screensaver again)

> Yes, I tested this briefly yesterday, and it seemed to work, but not

> always. I'll test more when I get home again.

> > this i can reproduce, i don't know much yet how to fix:

> > 310611 (accelerators)

> The code from Elias won't work?

Actually, that code belongs to basysKom (I mean the copyright) and I wrote it for them when I worked in basysKom's Contour project. Anyway, after some time researching I came to the conclusion that QML does not implement the concept of accelerators, so I had to emulate it in the QML shutdown dialog.

The problem with that implementation is how to list all buttons in a given window and only on that window so buttons in different windows but with the same accel key are not triggered at the same time. In QML shutdown dialog the list is hardcoded so this was not a big deal, to implement something similar in Plasma Components we need something better.

Lamarque V. Souza

KDE's Network Management maintainer

http://planetkde.org/pt-br

--Boundary-01=_30/7QLGEC/nLdtX--