[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request: qml based kwin shadow
From: Martin_Gräßlin <kde () martin-graesslin ! com>
Date: 2013-01-10 7:45:22
Message-ID: 20130110074522.22182.99748 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108243/#review25132
-----------------------------------------------------------
Ship it!
the duplication tells me we should someday add a shared base element for al=
l the different kinds of TabBoxes.
Apart from the issue below, it's fine to go in. Thanks for taking care of i=
t.
kwin/tabbox/qml/ShadowedSvgItem.qml
<http://git.reviewboard.kde.org/r/108243/#comment19221>
copyright missing
- Martin Gr=C3=A4=C3=9Flin
On Jan. 8, 2013, 12:21 a.m., Xuetian Weng wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108243/
> -----------------------------------------------------------
> =
> (Updated Jan. 8, 2013, 12:21 a.m.)
> =
> =
> Review request for kde-workspace, kwin, Plasma, Thomas L=C3=BCbking, Aaro=
n J. Seigo, Marco Martin, and Martin Gr=C3=A4=C3=9Flin.
> =
> =
> Description
> -------
> =
> This is a different solution solve problem in https://git.reviewboard.kde=
.org/r/108224/
> =
> 1. use qml to draw shadow in DeclarativeView.
> 2. set blur mask svg property in qml
> 3. and fix some layout problem in big icons and small icons.
> =
> =
> Diffs
> -----
> =
> kwin/tabbox/declarative.cpp 3bdcfac =
> kwin/tabbox/qml/CMakeLists.txt d4bc863 =
> kwin/tabbox/qml/IconTabBox.qml 23bb11b =
> kwin/tabbox/qml/ShadowedSvgItem.qml PRE-CREATION =
> kwin/tabbox/qml/clients/big_icons/contents/ui/main.qml 7115b7f =
> kwin/tabbox/qml/clients/compact/contents/ui/main.qml 1f6f036 =
> kwin/tabbox/qml/clients/informative/contents/ui/main.qml 3a2c4a3 =
> kwin/tabbox/qml/clients/present_windows/contents/ui/main.qml 14a54d3 =
> kwin/tabbox/qml/clients/small_icons/contents/ui/main.qml ea09ed0 =
> kwin/tabbox/qml/clients/text/contents/ui/main.qml c0def27 =
> kwin/tabbox/qml/clients/thumbnails/contents/ui/main.qml efe3ebe =
> kwin/tabbox/qml/tabbox.qml 4176231 =
> =
> Diff: http://git.reviewboard.kde.org/r/108243/diff/
> =
> =
> Testing
> -------
> =
> all desktop tabbox is tested with Air and Slim Glow, composite and non-co=
mposite, no problem.
> =
> =
> Thanks,
> =
> Xuetian Weng
> =
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/108243/">http://git.reviewboard.kde.org/r/108243/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">the duplication tells me \
we should someday add a shared base element for all the different kinds of TabBoxes.
Apart from the issue below, it's fine to go in. Thanks for taking care of \
it.</pre> <br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/108243/diff/5/?file=105748#file105748line1" \
style="color: black; font-weight: bold; text-decoration: \
underline;">kwin/tabbox/qml/ShadowedSvgItem.qml</a> <span style="font-weight: \
normal;">
(Diff revision 5)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
"></pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">1</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> \
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">copyright \
missing</pre> </div>
<br />
<p>- Martin</p>
<br />
<p>On January 8th, 2013, 12:21 a.m., Xuetian Weng wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kde-workspace, kwin, Plasma, Thomas Lübking, Aaron J. Seigo, \
Marco Martin, and Martin Gräßlin.</div> <div>By Xuetian Weng.</div>
<p style="color: grey;"><i>Updated Jan. 8, 2013, 12:21 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This is a different solution solve problem in \
https://git.reviewboard.kde.org/r/108224/
1. use qml to draw shadow in DeclarativeView.
2. set blur mask svg property in qml
3. and fix some layout problem in big icons and small icons.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">all desktop tabbox is tested with Air and Slim Glow, composite and \
non-composite, no problem.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kwin/tabbox/declarative.cpp <span style="color: grey">(3bdcfac)</span></li>
<li>kwin/tabbox/qml/CMakeLists.txt <span style="color: grey">(d4bc863)</span></li>
<li>kwin/tabbox/qml/IconTabBox.qml <span style="color: grey">(23bb11b)</span></li>
<li>kwin/tabbox/qml/ShadowedSvgItem.qml <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>kwin/tabbox/qml/clients/big_icons/contents/ui/main.qml <span style="color: \
grey">(7115b7f)</span></li>
<li>kwin/tabbox/qml/clients/compact/contents/ui/main.qml <span style="color: \
grey">(1f6f036)</span></li>
<li>kwin/tabbox/qml/clients/informative/contents/ui/main.qml <span style="color: \
grey">(3a2c4a3)</span></li>
<li>kwin/tabbox/qml/clients/present_windows/contents/ui/main.qml <span style="color: \
grey">(14a54d3)</span></li>
<li>kwin/tabbox/qml/clients/small_icons/contents/ui/main.qml <span style="color: \
grey">(ea09ed0)</span></li>
<li>kwin/tabbox/qml/clients/text/contents/ui/main.qml <span style="color: \
grey">(c0def27)</span></li>
<li>kwin/tabbox/qml/clients/thumbnails/contents/ui/main.qml <span style="color: \
grey">(efe3ebe)</span></li>
<li>kwin/tabbox/qml/tabbox.qml <span style="color: grey">(4176231)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/108243/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic