[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-core-devel
Subject: Re: Review Request: Fix bug 234407 - systemsettings iconview wordwrapping cause narrow icon in zhcn
From: Thomas_Lübking <thomas.luebking () gmail ! com>
Date: 2013-01-09 19:07:36
Message-ID: 20130109190736.30114.83512 () vidsolbach ! de
[Download RAW message or body]
> On Jan. 9, 2013, 6:43 p.m., Albert Astals Cid wrote:
> > To be honest i don't think this is the correct fix, the correct fix is specifying \
> > a minimum space between the items or a minimum size of the items themselves, not \
> > forcing the wordwrapping off
itemsize (spacing would also increase space between text) and it's actually the only \
way to fix the bug (look at the cn text of notifications or a11y) and scales better \
when eg. egypt returned to hieroglyphs or so ;-)
- Thomas
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108285/#review25091
-----------------------------------------------------------
On Jan. 9, 2013, 4:33 a.m., Chao Feng wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108285/
> -----------------------------------------------------------
>
> (Updated Jan. 9, 2013, 4:33 a.m.)
>
>
> Review request for kde-workspace.
>
>
> Description
> -------
>
> CJK languages do not use space as words seperator.
>
> And a CJK translation of the text in Systemsettings are very short. A single line \
> is enough for them.
>
> This addresses bug 234407.
> http://bugs.kde.org/show_bug.cgi?id=234407
>
>
> Diffs
> -----
>
> systemsettings/icons/IconMode.cpp 37cfc4bed42e4d05fc4c01008f8ca2c63b287b5e
>
> Diff: http://git.reviewboard.kde.org/r/108285/diff/
>
>
> Testing
> -------
>
> 1. Apply patch
> 2. Systemsetting show ok on CJK
>
>
> Thanks,
>
> Chao Feng
>
>
[Attachment #3 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/108285/">http://git.reviewboard.kde.org/r/108285/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On January 9th, 2013, 6:43 p.m., <b>Albert Astals \
Cid</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">To be honest i don't think this is the correct fix, the correct fix \
is specifying a minimum space between the items or a minimum size of the items \
themselves, not forcing the wordwrapping off</pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">itemsize (spacing would \
also increase space between text) and it's actually the only way to fix the bug \
(look at the cn text of notifications or a11y) and scales better when eg. egypt \
returned to hieroglyphs or so ;-)</pre> <br />
<p>- Thomas</p>
<br />
<p>On January 9th, 2013, 4:33 a.m., Chao Feng wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kde-workspace.</div>
<div>By Chao Feng.</div>
<p style="color: grey;"><i>Updated Jan. 9, 2013, 4:33 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">CJK languages do not use space as words seperator.
And a CJK translation of the text in Systemsettings are very short. A single line is \
enough for them. </pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">1. Apply patch 2. Systemsetting show ok on CJK</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=234407">234407</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>systemsettings/icons/IconMode.cpp <span style="color: \
grey">(37cfc4bed42e4d05fc4c01008f8ca2c63b287b5e)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/108285/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic