'Re: Review Request: Fix KWindowSystem::compositingChanged signal'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwin
Subject:    Re: Review Request: Fix KWindowSystem::compositingChanged signal
From:       Thomas_Lübking <thomas.luebking () web ! de>
Date:       2013-01-05 17:08:13
Message-ID: 20130105170813.12620.12946 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107983/
-----------------------------------------------------------

(Updated Jan. 5, 2013, 5:08 p.m.)

Review request for kdelibs, kwin, Plasma, Aaron J. Seigo, Marco Martin, Martin Gräßlin, and Fredrik \
Höglund.

Changes
-------

Modified patch to check the root event but let it unconditionally pass to Qt (to preserve other \
SelectionOwner notifications) This does also stop additional notifications on winId(), so my guess is \
that passing the root event simply causes something (Qt?!) to "steal" it from XFixes.

Remaining question is, whether the explicit XFixesSelectSelectionInput call is still required (or we do \
receive them anyway due to eg. Qt's cnp implementation - from the simple testcase the answer is "yes")

Summary (updated)
-----------------

Fix KWindowSystem::compositingChanged signal

Description
-------

It works fine here (tested so far KWindowSystem signal, KSelectionWatcher only with kwin) with kwin \
(shift+alt+f12), xcompmgr, compiz & "metacity -c" and e17. Didn't try xfce nor mutter.

Technically:
I do not at all understand why KWindowSystem is *not* watching the root window - KSelectionOwner for one \
is sending events to the root and this also seems the case for all other WMs (at least everything now \
starts to cause the signal to be emitted)

The KSelectionWatcher failure seems to be kwin specific (wrote me a cleaner testcase), there'll be some \
X11 event processing on top that eats away the client messages. So this one can be scratched from the \
patch, the KWindowSystem issue remains.

This addresses bug 179042.
    http://bugs.kde.org/show_bug.cgi?id=179042

Diffs (updated)
-----

  kdeui/windowmanagement/kwindowsystem_x11.cpp f9b3cc1 

Diff: http://git.reviewboard.kde.org/r/107983/diff/

Testing
-------

see summary

Thanks,

Thomas Lübking

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
    <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/107983/">http://git.reviewboard.kde.org/r/107983/</a>
     </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: \
left top; background-repeat: repeat-x; border: 1px black solid;">  <tr>
  <td>

<div>Review request for kdelibs, kwin, Plasma, Aaron J. Seigo, Marco Martin, Martin Gräßlin, and \
Fredrik Höglund.</div> <div>By Thomas Lübking.</div>

<p style="color: grey;"><i>Updated Jan. 5, 2013, 5:08 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Modified patch to check the root event but \
let it unconditionally pass to Qt (to preserve other SelectionOwner notifications) This does also stop \
additional notifications on winId(), so my guess is that passing the root event simply causes something \
(Qt?!) to &quot;steal&quot; it from XFixes.

Remaining question is, whether the explicit XFixesSelectSelectionInput call is still required (or we do \
receive them anyway due to eg. Qt&#39;s cnp implementation - from the simple testcase the answer is \
&quot;yes&quot;)</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Summary (updated)</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Fix KWindowSystem::compositingChanged \
signal</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid \
#b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">It works fine here (tested so far \
KWindowSystem signal, KSelectionWatcher only with kwin) with kwin (shift+alt+f12), xcompmgr, compiz &amp; \
&quot;metacity -c&quot; and e17. Didn&#39;t try xfce nor mutter.

Technically:
I do not at all understand why KWindowSystem is *not* watching the root window - KSelectionOwner for one \
is sending events to the root and this also seems the case for all other WMs (at least everything now \
starts to cause the signal to be emitted)

The KSelectionWatcher failure seems to be kwin specific (wrote me a cleaner testcase), there&#39;ll be \
some X11 event processing on top that eats away the client messages. So this one can be scratched from \
the patch, the KWindowSystem issue remains.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">see summary</pre>  </td>
 </tr>
</table>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>

 <a href="http://bugs.kde.org/show_bug.cgi?id=179042">179042</a>

</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> (updated)</h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>kdeui/windowmanagement/kwindowsystem_x11.cpp <span style="color: grey">(f9b3cc1)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/107983/diff/" style="margin-left: 3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin

[prev in list] [next in list] [prev in thread] [next in thread] 