[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-core-devel
Subject: Re: Review Request: Fix KSelectionWatcher / KWindowSystem::compositingChanged signal
From: "David Faure" <faure () kde ! org>
Date: 2013-01-04 8:42:21
Message-ID: 20130104084221.1405.64464 () vidsolbach ! de
[Download RAW message or body]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107983/#review24639
-----------------------------------------------------------
Oh! A man who understands KSelectionWatcher! I need your help. Could you look into KSelectionWatcher in \
the kdelibs-frameworks branch (with Qt5 installed), and port the kselectionwatcher unittest to the new \
kselectionwatcher API (fredrikh made it async, due to XCB being async, but didn't port the unittest)?
- David Faure
On Dec. 30, 2012, 4:45 p.m., Thomas Lübking wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107983/
> -----------------------------------------------------------
>
> (Updated Dec. 30, 2012, 4:45 p.m.)
>
>
> Review request for kdelibs, kwin, Aaron J. Seigo, Marco Martin, Martin Gräßlin, and Luboš Luňák.
>
>
> Description
> -------
>
> It works fine here (tested so far KWindowSystem signal, KSelectionWatcher only with kwin) with kwin \
> (shift+alt+f12), xcompmgr, compiz & "metacity -c" and e17. Didn't try xfce nor mutter.
>
> Technically:
> I do not at all understand why KWindowSystem is *not* watching the root window - KSelectionOwner for \
> one is sending events to the root and this also seems the case for all other WMs (at least everything \
> now starts to cause the signal to be emitted)
> As for SubstructureNotify, well, the message is sent to the root window - but the iccm suggests to send \
> by StructureNotify mask (http://tronche.com/gui/x/icccm/sec-2.html) bottom of the page. I just gave it \
> a wild shot ("hey, what if we tell everyone") and it absolutely reproducibly enables notification of \
> selectionwatcher constructed before the eventloop is up (while it also very much seems to be not \
> required once the eventloop is actually up) and i don't think it should hurt at all (but might hint a \
> problem in rather the selectionwatcher, since we cannot expect others to send by that mask)
>
> This addresses bug 179042.
> http://bugs.kde.org/show_bug.cgi?id=179042
>
>
> Diffs
> -----
>
> kdeui/util/kmanagerselection.cpp a289f47
> kdeui/windowmanagement/kwindowsystem_x11.cpp f9b3cc1
>
> Diff: http://git.reviewboard.kde.org/r/107983/diff/
>
>
> Testing
> -------
>
> see summary
>
>
> Thanks,
>
> Thomas Lübking
>
>
[Attachment #3 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/107983/">http://git.reviewboard.kde.org/r/107983/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: \
-o-pre-wrap; word-wrap: break-word;">Oh! A man who understands KSelectionWatcher! I need your help. Could \
you look into KSelectionWatcher in the kdelibs-frameworks branch (with Qt5 installed), and port the \
kselectionwatcher unittest to the new kselectionwatcher API (fredrikh made it async, due to XCB being \
async, but didn't port the unittest)?</pre> <br />
<p>- David</p>
<br />
<p>On December 30th, 2012, 4:45 p.m., Thomas Lübking wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: \
left top; background-repeat: repeat-x; border: 1px black solid;"> <tr>
<td>
<div>Review request for kdelibs, kwin, Aaron J. Seigo, Marco Martin, Martin Gräßlin, and Luboš \
Luňák.</div> <div>By Thomas Lübking.</div>
<p style="color: grey;"><i>Updated Dec. 30, 2012, 4:45 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid \
#b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">It works fine here (tested so far \
KWindowSystem signal, KSelectionWatcher only with kwin) with kwin (shift+alt+f12), xcompmgr, compiz & \
"metacity -c" and e17. Didn't try xfce nor mutter.
Technically:
I do not at all understand why KWindowSystem is *not* watching the root window - KSelectionOwner for one \
is sending events to the root and this also seems the case for all other WMs (at least everything now \
starts to cause the signal to be emitted)
As for SubstructureNotify, well, the message is sent to the root window - but the iccm suggests to send \
by StructureNotify mask (http://tronche.com/gui/x/icccm/sec-2.html) bottom of the page. I just gave it a \
wild shot ("hey, what if we tell everyone") and it absolutely reproducibly enables notification \
of selectionwatcher constructed before the eventloop is up (while it also very much seems to be not \
required once the eventloop is actually up) and i don't think it should hurt at all (but might hint a \
problem in rather the selectionwatcher, since we cannot expect others to send by that mask)</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">see summary</pre> </td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=179042">179042</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kdeui/util/kmanagerselection.cpp <span style="color: grey">(a289f47)</span></li>
<li>kdeui/windowmanagement/kwindowsystem_x11.cpp <span style="color: grey">(f9b3cc1)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/107983/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic