[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: Moving libkfacebook to extragear
From:       Albert Astals Cid <aacid () kde ! org>
Date:       2013-01-03 20:52:28
Message-ID: 2773424.i6iHCIXHYp () xps
[Download RAW message or body]

El Dimecres, 2 de gener de 2013, a les 15:31:30, Martin Klapetek va escriure:
> On Sun, Dec 30, 2012 at 6:34 PM, Albert Astals Cid <aacid@kde.org> wrote:
> > AttendeeInfo misses a d_ptr?
> 
> Are you deleting the d_ptr? Maybe i'm missing something but for example you
> 
> > don't seem to delete the d_ptr of PagedListJob, no?
> 
> I reworked the dpointers a bit, classes deriving directly from Facebook*Job
> are now extending its dpointer, which is then deleted in the baseclass
> (FacebookJob). All other dpointers are also properly deleted.
> Partly-related - our d-pointer tutorials don't delete it either [1][2].

The QScopedPointer will do the trick, no?

Cheers,
  Albert

> 
> > You probably also want to add Q_DISABLE_COPY to most of the classes with
> > d-pointers, otherwise the default constructor and operator= will do
> > something
> > that you don't really want.
> 
> Fixed.
> 
> [1] - http://techbase.kde.org/Policies/Library_Code_Policy#D-Pointers
> [2] -
> http://techbase.kde.org/Policies/Library_Code_Policy/Shared_D-Pointer_Exampl
> e
> 
> Cheers
[prev in list] [next in list] [prev in thread] [next in thread]