'Review Request: Don't add qml elements twice to the scene, reduce warnings'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Review Request: Don't add qml elements twice to the scene, reduce warnings
From:       "Aleix Pol Gonzalez" <aleixpol () gmail ! com>
Date:       2013-01-02 14:20:41
Message-ID: 20130102142041.1817.59964 () vidsolbach ! de
[Download RAW message or body]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108079/
-----------------------------------------------------------

Review request for kdelibs, Plasma and Marco Martin.


Description
-------

don't addItem to the scene after calling setParentItem. It's redundant acco=
rding to the api documentation and removes a warning.


Diffs
-----

  plasma/widgets/declarativewidget.cpp 81f09c3 =


Diff: http://git.reviewboard.kde.org/r/108079/diff/


Testing
-------

Ran some plasmoids, works fine.


Thanks,

Aleix Pol Gonzalez


[Attachment #3 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
    <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/108079/">http://git.reviewboard.kde.org/r/108079/</a>
     </td>
    </tr>
   </table>
   <br />


<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: \
left top; background-repeat: repeat-x; border: 1px black solid;">  <tr>
  <td>

<div>Review request for kdelibs, Plasma and Marco Martin.</div>
<div>By Aleix Pol Gonzalez.</div>







<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid \
#b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">don&#39;t addItem to the scene after calling \
setParentItem. It&#39;s redundant according to the api documentation and removes a warning.</pre>  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ran some plasmoids, works fine.</pre>  </td>
 </tr>
</table>




<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>plasma/widgets/declarativewidget.cpp <span style="color: grey">(81f09c3)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/108079/diff/" style="margin-left: 3em;">View Diff</a></p>




  </td>
 </tr>
</table>




  </div>
 </body>
</html>



[prev in list] [next in list] [prev in thread] [next in thread]
Configure | About | News | Add a list | Sponsored by KoreLogic