--14dae934036f00ce1404d24f1c2c
Content-Type: text/plain; charset=UTF-8

On Sun, Dec 30, 2012 at 6:34 PM, Albert Astals Cid <aacid@kde.org> wrote:

>
> AttendeeInfo misses a d_ptr?

Are you deleting the d_ptr? Maybe i'm missing something but for example you
> don't seem to delete the d_ptr of PagedListJob, no?
>

I reworked the dpointers a bit, classes deriving directly from Facebook*Job
are now extending its dpointer, which is then deleted in the baseclass
(FacebookJob). All other dpointers are also properly deleted.
Partly-related - our d-pointer tutorials don't delete it either [1][2].


> You probably also want to add Q_DISABLE_COPY to most of the classes with
> d-pointers, otherwise the default constructor and operator= will do
> something
> that you don't really want.
>

Fixed.

[1] - http://techbase.kde.org/Policies/Library_Code_Policy#D-Pointers
[2] -
http://techbase.kde.org/Policies/Library_Code_Policy/Shared_D-Pointer_Example

Cheers
-- 
Martin Klapetek | KDE Developer

--14dae934036f00ce1404d24f1c2c
Content-Type: text/html; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

On Sun, Dec 30, 2012 at 6:34 PM, Albert Astals Cid <span dir=3D"ltr">&lt;<a=
 href=3D"mailto:aacid@kde.org" target=3D"_blank">aacid@kde.org</a>&gt;</spa=
n> wrote:<br><div class=3D"gmail_quote"><blockquote class=3D"gmail_quote" s=
tyle=3D"margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">


<div><br>
</div>AttendeeInfo misses a d_ptr?</blockquote><blockquote class=3D"gmail_q=
uote" style=3D"margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1e=
x">
Are you deleting the d_ptr? Maybe i&#39;m missing something but for example=
 you<br>
don&#39;t seem to delete the d_ptr of PagedListJob, no?<br></blockquote><di=
v><br></div><div>I reworked the dpointers a bit, classes deriving directly =
from Facebook*Job are now extending its dpointer, which is then deleted in =
the baseclass (FacebookJob). All other dpointers are also properly deleted.=
 Partly-related - our d-pointer tutorials don&#39;t delete it either [1][2]=
.</div>

<div>=C2=A0</div><blockquote class=3D"gmail_quote" style=3D"margin:0 0 0 .8=
ex;border-left:1px #ccc solid;padding-left:1ex">

You probably also want to add Q_DISABLE_COPY to most of the classes with<br=
>
d-pointers, otherwise the default constructor and operator=3D will do somet=
hing<br>
that you don&#39;t really want.<br></blockquote><div><br></div><div>Fixed.<=
/div><div><br></div><div>[1] -=C2=A0<a href=3D"http://techbase.kde.org/Poli=
cies/Library_Code_Policy#D-Pointers" target=3D"_blank">http://techbase.kde.=
org/Policies/Library_Code_Policy#D-Pointers</a></div>


<div>[2] -=C2=A0<a href=3D"http://techbase.kde.org/Policies/Library_Code_Po=
licy/Shared_D-Pointer_Example" target=3D"_blank">http://techbase.kde.org/Po=
licies/Library_Code_Policy/Shared_D-Pointer_Example</a></div><div>=C2=A0</d=
iv><div>Cheers</div>

</div>-- <br>
<div><span style=3D"color:rgb(102,102,102)">Martin Klapetek | KDE=C2=A0Deve=
loper</span></div>

--14dae934036f00ce1404d24f1c2c--