[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: Moving libkfacebook to extragear
From:       Alexander Neundorf <neundorf () kde ! org>
Date:       2012-12-30 16:35:43
Message-ID: 201212301735.43889.neundorf () kde ! org
[Download RAW message or body]

On Sunday 30 December 2012, Albert Astals Cid wrote:
> El Dissabte, 29 de desembre de 2012, a les 01:25:43, Martin Klapetek va
> 
> escriure:
> > On Wed, Nov 7, 2012 at 8:11 PM, Albert Astals Cid <aacid@kde.org> wrote:
> > > > The data classes are finally done - all of them now use d-pointers
> > > > and
> > > 
> > > none
> > > 
> > > > are qobject; I've added the qobject-parsers as Kevin suggested,
> > > > please
> > > 
> > > give
> > > 
> > > > it a look.
> > > 
> > > You sure? I still see a lots of d-pointers missing (AllEventsListJob,
> > > AllNotesListJob, etc).
> > 
> > I finally got around finishing d-pointerizing the whole library, it's all
> > in master now. Please review.
> 
> What's config.h.cmake used for?

... and please rename it to config.h.in (using .cmake as a suffix was not a 
very good idea, main motivation was to make it painless to have the 
config.h.in for autotools and config.h.cmake for cmake exist in parallel when 
we switched to cmake back in 2006).

Alex
[prev in list] [next in list] [prev in thread] [next in thread]