[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-core-devel
Subject: Review Request: Fix KSelectionWatcher / KWindowSystem::compositingChanged signal
From: Thomas_Lübking <thomas.luebking () web ! de>
Date: 2012-12-28 16:17:36
Message-ID: 20121228161736.8676.40582 () vidsolbach ! de
[Download RAW message or body]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107983/
-----------------------------------------------------------
Review request for kdelibs, kwin, Aaron J. Seigo, Marco Martin, Martin Gräßlin, and \
Luboš Luňák.
Description
-------
It works fine here (tested so far KWindowSystem signal, KSelectionWatcher only with \
kwin) with kwin (shift+alt+f12), xcompmgr, compiz & "metacity -c" I'll also give it a \
try with e17 and for xfce we just hope the best? ;-)
Technically:
I do not at all understand why KWindowSystem is *not* watching the root window - \
KSelectionOwner for one is sending events to the root and this also seems the case \
for all other WMs (at least everything now starts to cause the signal to be emitted)
As for SubstructureNotify, well, the message is sent to the root window - but the \
iccm suggests to send by StructureNotify mask \
(http://tronche.com/gui/x/icccm/sec-2.html) bottom of the page. I just gave it a wild \
shot ("hey, what if we tell everyone") and it absolutely reproducibly enables \
notification of selectionwatcher constructed before the eventloop is up (while it \
also very much seems to be not required once the eventloop is actually up) and i \
don't think it should hurt at all (but might hint a problem in rather the \
selectionwatcher, since we cannot expect others to send by that mask)
This addresses bug 179042.
http://bugs.kde.org/show_bug.cgi?id=179042
Diffs
-----
kdeui/util/kmanagerselection.cpp a289f47
kdeui/windowmanagement/kwindowsystem_x11.cpp f9b3cc1
Diff: http://git.reviewboard.kde.org/r/107983/diff/
Testing
-------
see summary
Thanks,
Thomas Lübking
[Attachment #3 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/107983/">http://git.reviewboard.kde.org/r/107983/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kdelibs, kwin, Aaron J. Seigo, Marco Martin, Martin \
Gräßlin, and Luboš Luňák.</div> <div>By Thomas Lübking.</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">It works fine here (tested so far KWindowSystem signal, \
KSelectionWatcher only with kwin) with kwin (shift+alt+f12), xcompmgr, compiz & \
"metacity -c" I'll also give it a try with e17 and for xfce we just \
hope the best? ;-)
Technically:
I do not at all understand why KWindowSystem is *not* watching the root window - \
KSelectionOwner for one is sending events to the root and this also seems the case \
for all other WMs (at least everything now starts to cause the signal to be emitted)
As for SubstructureNotify, well, the message is sent to the root window - but the \
iccm suggests to send by StructureNotify mask \
(http://tronche.com/gui/x/icccm/sec-2.html) bottom of the page. I just gave it a wild \
shot ("hey, what if we tell everyone") and it absolutely reproducibly \
enables notification of selectionwatcher constructed before the eventloop is up \
(while it also very much seems to be not required once the eventloop is actually up) \
and i don't think it should hurt at all (but might hint a problem in rather the \
selectionwatcher, since we cannot expect others to send by that mask)</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">see summary</pre> </td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=179042">179042</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kdeui/util/kmanagerselection.cpp <span style="color: grey">(a289f47)</span></li>
<li>kdeui/windowmanagement/kwindowsystem_x11.cpp <span style="color: \
grey">(f9b3cc1)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/107983/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic