[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    plasma and new shadow mess
From:       Weng Xuetian <wengxt () gmail ! com>
Date:       2012-12-24 22:12:22
Message-ID: CAKiDycFWZ1qkvrnWnVv5swmm5Qz84rY=einqXLv+0vqFodGJPQ () mail ! gmail ! com
[Download RAW message or body]

Hi Plasma world,
As new shadow lands in KDE 4.10 RC1, some unintentional mess is introduced.

https://bugs.kde.org/show_bug.cgi?id=311502
https://bugs.kde.org/show_bug.cgi?id=311995

And it affects some more components, at least including kmix osd,
brightness osd, icontasks.

The problem is, custom widget using plasma svg doesn't get new shadow
support automatically, some code must be written.

I observe that some components get necessary modifications, for example
krunner, while also quite a few of them still not.

What make this problem worse is, the necessary class for shadow is not
public. And AFAIK there are already 3 copies of same code across different
kde projects (kdelibs/plasma/private/dialogshadows ,
kde-workspace/libs/plasmagenericshell/panelshadows, and one of my own in
kdeplasma-addons), plasmagenericshell is a shared library but it doesn't
install header..

I think some action need to be taken before the release, some possible
solutions.
1. Revert the changes of new plasma air theme, so old shadow can be used.
and try to fix all the things in KDE 4.11
or 2. get some header exposed to avoid duplication of the code, and fixed
every custom widget, at least including: kwin, kmix, powerdevil, icontasks.

I can give out my help for fix those, but some decision still need to be
made (add new header to kdelibs or kde-workspace).

Regards

[Attachment #3 (text/html)]

<div dir="ltr"><div><div><div>Hi Plasma world,<br></div>As new shadow lands in KDE \
4.10 RC1, some unintentional mess is introduced.<br><br><a \
href="https://bugs.kde.org/show_bug.cgi?id=311502">https://bugs.kde.org/show_bug.cgi?id=311502</a><br>
 <a href="https://bugs.kde.org/show_bug.cgi?id=311995">https://bugs.kde.org/show_bug.cgi?id=311995</a><br><br></div>And \
it affects some more components, at least including kmix osd, brightness osd, \
icontasks.<br><br>The problem is, custom widget using plasma svg doesn&#39;t get new \
shadow support automatically, some code must be written.<br> <br></div><div>I observe \
that some components get necessary modifications, for example krunner, while also \
quite a few of them still not.<br><br></div><div>What make this problem worse is, the \
necessary class for shadow is not public. And AFAIK there are already 3 copies of \
same code across different kde projects (kdelibs/plasma/private/dialogshadows , \
kde-workspace/libs/plasmagenericshell/panelshadows, and one of my own in \
kdeplasma-addons), plasmagenericshell is a shared library but it doesn&#39;t install \
header..<br> <br></div><div>I think some action need to be taken before the release, \
some possible solutions.<br></div><div>1. Revert the changes of new plasma air theme, \
so old shadow can be used. and try to fix all the things in KDE 4.11<br> \
</div><div>or 2. get some header exposed to avoid duplication of the code, and fixed \
every custom widget, at least including: kwin, kmix, powerdevil, \
icontasks.<br><br></div><div>I can give out my help for fix those, but some decision \
still need to be made (add new header to kdelibs or kde-workspace).<br> \
<br></div><div>Regards<br></div></div>



[prev in list] [next in list] [prev in thread] [next in thread]