[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: Review Request: Fix icon generation and installation on OS X
From:       "Yue Liu" <yue.liu () mail ! com>
Date:       2012-12-20 18:10:39
Message-ID: 20121220181039.28182.65814 () vidsolbach ! de
[Download RAW message or body]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107752/
-----------------------------------------------------------

(Updated Dec. 20, 2012, 6:10 p.m.)


Review request for kdelibs.


Changes
-------

changed repeated codes with a macro


Description
-------

There are two issues when using kde4_add_app_icon on mac. a) apps using kde=
init won't install icon files to thier app bundles, b) mac app icon generat=
ing method is outdated and does not support retina resolution.

The patch changed kde4_add_kdeinit_executable and kde4_add_app_icon to solv=
e these issues.


Diffs (updated)
-----

  cmake/modules/KDE4Macros.cmake 0753879 =


Diff: http://git.reviewboard.kde.org/r/107752/diff/


Testing
-------

Works well on 4.9 branch.
Not sure if some changes breaks other platforms.


Thanks,

Yue Liu


[Attachment #3 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/107752/">http://git.reviewboard.kde.org/r/107752/</a>
  </td>
    </tr>
   </table>
   <br />


<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for kdelibs.</div>
<div>By Yue Liu.</div>


<p style="color: grey;"><i>Updated Dec. 20, 2012, 6:10 p.m.</i></p>



<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">changed repeated codes with a macro</pre>  </td>
 </tr>
</table>




<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">There are two issues when using kde4_add_app_icon on mac. a) apps using \
kdeinit won&#39;t install icon files to thier app bundles, b) mac app icon generating \
method is outdated and does not support retina resolution.

The patch changed kde4_add_kdeinit_executable and kde4_add_app_icon to solve these \
issues.</pre>  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Works well on 4.9 branch. Not sure if some changes breaks other \
platforms.</pre>  </td>
 </tr>
</table>




<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
(updated)</h1> <ul style="margin-left: 3em; padding-left: 0;">

 <li>cmake/modules/KDE4Macros.cmake <span style="color: grey">(0753879)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/107752/diff/" style="margin-left: \
3em;">View Diff</a></p>




  </td>
 </tr>
</table>




  </div>
 </body>
</html>



[prev in list] [next in list] [prev in thread] [next in thread]

Configure | About | News | Add a list | Sponsored by KoreLogic