[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-core-devel
Subject: Re: Review Request: Make sure ksmserver ignores excluded apps when saving session
From: "Jekyll Wu" <adaptee () gmail ! com>
Date: 2012-12-09 7:50:13
Message-ID: 20121209075013.6663.73242 () vidsolbach ! de
[Download RAW message or body]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107276/
-----------------------------------------------------------
(Updated Dec. 9, 2012, 7:50 a.m.)
Review request for kdelibs, Plasma and Luboš Luňák.
Changes
-------
update the patch to also work with condition 4)
update the description to reflect the patch change
Description (updated)
-------
It is easy to understand why the existing code (usually) fails:
* Users are most likely to just specify short names, like \
"dolphin,gwenview,okular,rekonq", instead of \
"/usr/bin/konsole,/usr/bin/gwenview,/usr/bin/okular,/usr/bin/rekonq"
* When ksmserver saves the session, it usually gets the full names, like \
"/usr/bin/dolphin", unless you have started that dolphin instance by typing "dolphin" \
exactly in a shell.
So there are four possible combinations :
1). config uses short name, runtime gets short name (this guy starts everything \
from konsole, never using kio/krun) 2). config uses short name, runtime gets long \
name (I think this is the most common one) 3). config uses long name, runtime gets \
short name 4). config uses long name, runtime gets long name (I guess some users \
use this combination because they find only that way works after trying various \
workaround...)
The existing code works with 1) and 4), the patch now works with 1), 2) and 4) . I \
don't know whether it make senses to support all combinations .
This addresses bug 242760.
http://bugs.kde.org/show_bug.cgi?id=242760
Diffs (updated)
-----
ksmserver/server.cpp a65b35a
Diff: http://git.reviewboard.kde.org/r/107276/diff/
Testing
-------
Thanks,
Jekyll Wu
[Attachment #3 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/107276/">http://git.reviewboard.kde.org/r/107276/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kdelibs, Plasma and Luboš Luňák.</div>
<div>By Jekyll Wu.</div>
<p style="color: grey;"><i>Updated Dec. 9, 2012, 7:50 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">update the patch to also work with condition 4) update the description \
to reflect the patch change</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description \
(updated)</h1> <table width="100%" bgcolor="#ffffff" cellspacing="0" \
cellpadding="10" style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">It is easy to understand why the existing code (usually) fails:
* Users are most likely to just specify short names, like \
"dolphin,gwenview,okular,rekonq", instead of \
"/usr/bin/konsole,/usr/bin/gwenview,/usr/bin/okular,/usr/bin/rekonq"
* When ksmserver saves the session, it usually gets the full names, like \
"/usr/bin/dolphin", unless you have started that dolphin instance by typing \
"dolphin" exactly in a shell.
So there are four possible combinations :
1). config uses short name, runtime gets short name (this guy starts everything \
from konsole, never using kio/krun) 2). config uses short name, runtime gets long \
name (I think this is the most common one) 3). config uses long name, runtime gets \
short name 4). config uses long name, runtime gets long name (I guess some users \
use this combination because they find only that way works after trying various \
workaround...)
The existing code works with 1) and 4), the patch now works with 1), 2) and 4) . I \
don't know whether it make senses to support all combinations .
</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=242760">242760</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
(updated)</h1> <ul style="margin-left: 3em; padding-left: 0;">
<li>ksmserver/server.cpp <span style="color: grey">(a65b35a)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/107276/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic