[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-core-devel
Subject: Re: Review Request: Make sure ksmserver ignores excluded apps when saving session
From: Luboš Luňák <l.lunak () kde ! org>
Date: 2012-12-06 16:17:22
Message-ID: 20121206161722.16685.58652 () vidsolbach ! de
[Download RAW message or body]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107276/#review23084
-----------------------------------------------------------
Sorry for the late reply, I'm not active in KDE anymore (and so I guess this means \
ksmserver is unmaintained).
The patch looks ok, but it makes sense to support 4) as well, so please add || \
excludeApps.contains( program.toLower()) too and then it's ok. Supporting 3) is most \
probably a bad idea.
- Luboš Luňák
On Nov. 10, 2012, 12:45 p.m., Jekyll Wu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107276/
> -----------------------------------------------------------
>
> (Updated Nov. 10, 2012, 12:45 p.m.)
>
>
> Review request for kdelibs, Plasma and Luboš Luňák.
>
>
> Description
> -------
>
> It is easy to understand why the existing code (usually) fails:
>
> * Users are most likely to just specify short names, like \
> "dolphin,gwenview,okular,rekonq", instead of \
> "/usr/bin/konsole,/usr/bin/gwenview,/usr/bin/okular,/usr/bin/rekonq"
> * When ksmserver saves the session, it usually gets the full names, like \
> "/usr/bin/dolphin", unless you have started that dolphin instance by typing \
> "dolphin" exactly in a shell.
>
> So there are four possible combinations :
>
> 1). config uses short name, runtime gets short name (this guy starts everything \
> from konsole, never using kio/krun) 2). config uses short name, runtime gets long \
> name (I think this is the most common one) 3). config uses long name, runtime gets \
> short name 4). config uses long name, runtime gets long name (I guess some users \
> use this combination because they find only that way works after trying various \
> workaround...)
> The existing code works with 1) and 4), this patch works with 1) and 2) . I don't \
> know whether it make senses to support all combinations
>
>
>
>
> This addresses bug 242760.
> http://bugs.kde.org/show_bug.cgi?id=242760
>
>
> Diffs
> -----
>
> ksmserver/server.cpp eb3ac18
>
> Diff: http://git.reviewboard.kde.org/r/107276/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jekyll Wu
>
>
[Attachment #3 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/107276/">http://git.reviewboard.kde.org/r/107276/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Sorry for the late \
reply, I'm not active in KDE anymore (and so I guess this means ksmserver is \
unmaintained).
The patch looks ok, but it makes sense to support 4) as well, so please add || \
excludeApps.contains( program.toLower()) too and then it's ok. Supporting 3) is \
most probably a bad idea.</pre> <br />
<p>- Luboš</p>
<br />
<p>On November 10th, 2012, 12:45 p.m., Jekyll Wu wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kdelibs, Plasma and Luboš Luňák.</div>
<div>By Jekyll Wu.</div>
<p style="color: grey;"><i>Updated Nov. 10, 2012, 12:45 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">It is easy to understand why the existing code (usually) fails:
* Users are most likely to just specify short names, like \
"dolphin,gwenview,okular,rekonq", instead of \
"/usr/bin/konsole,/usr/bin/gwenview,/usr/bin/okular,/usr/bin/rekonq"
* When ksmserver saves the session, it usually gets the full names, like \
"/usr/bin/dolphin", unless you have started that dolphin instance by typing \
"dolphin" exactly in a shell.
So there are four possible combinations :
1). config uses short name, runtime gets short name (this guy starts everything \
from konsole, never using kio/krun) 2). config uses short name, runtime gets long \
name (I think this is the most common one) 3). config uses long name, runtime gets \
short name 4). config uses long name, runtime gets long name (I guess some users \
use this combination because they find only that way works after trying various \
workaround...)
The existing code works with 1) and 4), this patch works with 1) and 2) . I don't \
know whether it make senses to support all combinations
</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=242760">242760</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>ksmserver/server.cpp <span style="color: grey">(eb3ac18)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/107276/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic