[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-core-devel
Subject: Re: Review Request: Use static KNS3::DownloadDialog in PlasmoidPackage
From: "Aaron J. Seigo" <aseigo () kde ! org>
Date: 2012-11-23 0:00:47
Message-ID: 20121123000047.28772.85484 () vidsolbach ! de
[Download RAW message or body]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107413/#review22405
-----------------------------------------------------------
plasma/private/packages.cpp
<http://git.reviewboard.kde.org/r/107413/#comment17178>
and this blocks the entire UI which is not acceptable .. which is why show rather \
than exec is used.
- Aaron J. Seigo
On Nov. 22, 2012, 7:08 p.m., Jan Grulich wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107413/
> -----------------------------------------------------------
>
> (Updated Nov. 22, 2012, 7:08 p.m.)
>
>
> Review request for kdelibs and Plasma.
>
>
> Description
> -------
>
> Switch from QWeakPointer to staticaly created KNS3::DownloadDialog like in some \
> KControl modules (i.e color scheme) to fix the problem when the list with widgets \
> is not downloaded every time you open it. Should fix this issue \
> https://bugzilla.redhat.com/show_bug.cgi?id=877021
>
> Diffs
> -----
>
> plasma/private/packages.cpp 2519341
> plasma/private/packages_p.h 15fde41
>
> Diff: http://git.reviewboard.kde.org/r/107413/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jan Grulich
>
>
[Attachment #3 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/107413/">http://git.reviewboard.kde.org/r/107413/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/107413/diff/1/?file=95820#file95820line114" \
style="color: black; font-weight: bold; text-decoration: \
underline;">plasma/private/packages.cpp</a> <span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void \
PlasmoidPackage::pathChanged()</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">114</font></th> <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">knsDialog</span><span class="o"><span class="hl">-></span></span><span \
class="n"><span class="hl">show</span></span><span class="p">();</span></pre></td> \
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">105</font></th> <td bgcolor="#fdfebc" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">knsDialog</span><span class="p"><span class="hl">.</span></span><span \
class="n"><span class="hl">exec</span></span><span class="p">();</span></pre></td> \
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">and this \
blocks the entire UI which is not acceptable .. which is why show rather than exec is \
used.</pre> </div>
<br />
<p>- Aaron J.</p>
<br />
<p>On November 22nd, 2012, 7:08 p.m., Jan Grulich wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kdelibs and Plasma.</div>
<div>By Jan Grulich.</div>
<p style="color: grey;"><i>Updated Nov. 22, 2012, 7:08 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Switch from QWeakPointer to staticaly created KNS3::DownloadDialog like \
in some KControl modules (i.e color scheme) to fix the problem when the list with \
widgets is not downloaded every time you open it. Should fix this issue \
https://bugzilla.redhat.com/show_bug.cgi?id=877021</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>plasma/private/packages.cpp <span style="color: grey">(2519341)</span></li>
<li>plasma/private/packages_p.h <span style="color: grey">(15fde41)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/107413/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic