[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-core-devel
Subject: Re: Review Request: favicon local cache
From: "Jaime Torres Amate" <jtamate () gmail ! com>
Date: 2012-11-20 19:34:17
Message-ID: 20121120193417.28085.3792 () vidsolbach ! de
[Download RAW message or body]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107358/
-----------------------------------------------------------
(Updated Nov. 20, 2012, 7:34 p.m.)
Review request for kdelibs.
Changes
-------
Added comment explaining the cache issue and the update problem.
Only one hash lookup now.
Added a counter to clear the cache from time to time (depending on the number of \
requests, not time). If you think this counter is not necessary, I can remove it.
Description
-------
Does not fix the bugs (I'll not mark them as fixed), but makes them much harder to \
reproduce. Just use a static QHash most of the time instead of a blocking Dbus call.
This addresses bugs 306338 and 307973.
http://bugs.kde.org/show_bug.cgi?id=306338
http://bugs.kde.org/show_bug.cgi?id=307973
Diffs (updated)
-----
kdecore/services/kmimetype.cpp 955bf62
Diff: http://git.reviewboard.kde.org/r/107358/diff/
Testing
-------
In my tests, there are more than 5 thousands requests for a favicon answered by the \
local cache vs. less than new 50 favicons inserted.
Thanks,
Jaime Torres Amate
[Attachment #3 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/107358/">http://git.reviewboard.kde.org/r/107358/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kdelibs.</div>
<div>By Jaime Torres Amate.</div>
<p style="color: grey;"><i>Updated Nov. 20, 2012, 7:34 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Added comment explaining the cache issue and the update problem. Only \
one hash lookup now.
Added a counter to clear the cache from time to time (depending on the number of \
requests, not time). If you think this counter is not necessary, I can remove \
it.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Does not fix the bugs (I'll not mark them as fixed), but makes them \
much harder to reproduce. Just use a static QHash most of the time instead of a \
blocking Dbus call.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">In my tests, there are more than 5 thousands requests for a favicon \
answered by the local cache vs. less than new 50 favicons inserted.</pre> </td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=306338">306338</a>,
<a href="http://bugs.kde.org/show_bug.cgi?id=307973">307973</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
(updated)</h1> <ul style="margin-left: 3em; padding-left: 0;">
<li>kdecore/services/kmimetype.cpp <span style="color: grey">(955bf62)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/107358/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic