[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-core-devel
Subject: Re: Review Request: parenthesis and not null checking
From: "Rolf Eike Beer" <kde () opensource ! sf-tec ! de>
Date: 2012-11-10 22:21:01
Message-ID: 20121110222101.24587.24831 () vidsolbach ! de
[Download RAW message or body]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107213/#review21785
-----------------------------------------------------------
A simple way to verify if this is correct is check if you and the compiler agree on the code. Run "make \
-n" in the build tree to get the full compiler command line, then insert a "-S" (assuming you are using \
gcc) and change the -o to point to a temporary file. This will output the assembler code. Do this with \
and without your modifications and look if the result is still the same.
- Rolf Eike Beer
On Nov. 5, 2012, 3:13 p.m., Jaime Torres Amate wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107213/
> -----------------------------------------------------------
>
> (Updated Nov. 5, 2012, 3:13 p.m.)
>
>
> Review request for kdelibs.
>
>
> Description
> -------
>
> place some parenthesis around ! operators, with less priority than ^ operators.
> place some parenthesis around = inside conditions
> check for n not being null before using it
> simplify if (a==true) return true else return false;
>
>
> Diffs
> -----
>
> khtml/khtml_caret.cpp 45fd90c
> khtml/rendering/render_inline.cpp acfc1e4
> khtml/rendering/render_object.cpp f37627c
> solid/solid/backends/wmi/wmiopticaldisc.cpp c6e390f
>
> Diff: http://git.reviewboard.kde.org/r/107213/diff/
>
>
> Testing
> -------
>
> I've been using this code several weeks.
>
>
> Thanks,
>
> Jaime Torres Amate
>
>
[Attachment #3 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/107213/">http://git.reviewboard.kde.org/r/107213/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: \
-o-pre-wrap; word-wrap: break-word;">A simple way to verify if this is correct is check if you and the \
compiler agree on the code. Run "make -n" in the build tree to get the full compiler command \
line, then insert a "-S" (assuming you are using gcc) and change the -o to point to a temporary \
file. This will output the assembler code. Do this with and without your modifications and look if the \
result is still the same.</pre> <br />
<p>- Rolf Eike</p>
<br />
<p>On November 5th, 2012, 3:13 p.m., Jaime Torres Amate wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: \
left top; background-repeat: repeat-x; border: 1px black solid;"> <tr>
<td>
<div>Review request for kdelibs.</div>
<div>By Jaime Torres Amate.</div>
<p style="color: grey;"><i>Updated Nov. 5, 2012, 3:13 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid \
#b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">place some parenthesis around ! operators, \
with less priority than ^ operators. place some parenthesis around = inside conditions
check for n not being null before using it
simplify if (a==true) return true else return false;
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I've been using this code several \
weeks.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>khtml/khtml_caret.cpp <span style="color: grey">(45fd90c)</span></li>
<li>khtml/rendering/render_inline.cpp <span style="color: grey">(acfc1e4)</span></li>
<li>khtml/rendering/render_object.cpp <span style="color: grey">(f37627c)</span></li>
<li>solid/solid/backends/wmi/wmiopticaldisc.cpp <span style="color: grey">(c6e390f)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/107213/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic