[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-core-devel
Subject: Re: Review Request: This change will allow the user to see keyboard layout visually
From: Àlex_Fiestas <afiestas () kde ! org>
Date: 2012-11-07 9:27:50
Message-ID: 20121107092750.2885.22135 () vidsolbach ! de
[Download RAW message or body]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107202/#review21534
-----------------------------------------------------------
Was this review? I don't see the ship it.
Also, kde-workspace is not compiling right now because: /keyboardpainter.cp=
p:20:32: fatal error: ui_keyboardpainter.h: No such file...
- =C3=80lex Fiestas
On Nov. 6, 2012, 4:53 a.m., Andriy Rysin wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107202/
> -----------------------------------------------------------
> =
> (Updated Nov. 6, 2012, 4:53 a.m.)
> =
> =
> Review request for KDE Runtime and Shaun Reich.
> =
> =
> Description
> -------
> =
> Keyboard layout preview feature
> =
> =
> Diffs
> -----
> =
> kcontrol/keyboard/CMakeLists.txt 29de717975d37949448a922c2297674a796a97=
c1 =
> kcontrol/keyboard/Messages.sh 0779aacf810c086c424d4ff946bbcb800492eb84 =
> kcontrol/keyboard/kcm_add_layout_dialog.h 6c6a795161d95d5203b5943ead6a7=
787e29ffd67 =
> kcontrol/keyboard/kcm_add_layout_dialog.cpp 34c97163d9267da34ad948347f7=
cc35b556fdaeb =
> kcontrol/keyboard/kcm_add_layout_dialog.ui b73080d08d6281c4f67d079ab016=
a3df50821012 =
> kcontrol/keyboard/kcm_keyboard.ui 22968e8644cae700efe505fde437d332aa951=
4ed =
> kcontrol/keyboard/kcm_keyboard_widget.h fa912c7f7daa497c20e3ce7ec4e4088=
2d7d980af =
> kcontrol/keyboard/kcm_keyboard_widget.cpp e1bd830bca8d308470dbba40e5e5a=
0127672798b =
> kcontrol/keyboard/preview/TODO PRE-CREATION =
> kcontrol/keyboard/preview/kbpreviewframe.h PRE-CREATION =
> kcontrol/keyboard/preview/kbpreviewframe.cpp PRE-CREATION =
> kcontrol/keyboard/preview/keyaliases.h PRE-CREATION =
> kcontrol/keyboard/preview/keyaliases.cpp PRE-CREATION =
> kcontrol/keyboard/preview/keyboardlayout.h PRE-CREATION =
> kcontrol/keyboard/preview/keyboardlayout.cpp PRE-CREATION =
> kcontrol/keyboard/preview/keyboardpainter.h PRE-CREATION =
> kcontrol/keyboard/preview/keyboardpainter.cpp PRE-CREATION =
> kcontrol/keyboard/preview/keysym2ucs.h PRE-CREATION =
> kcontrol/keyboard/preview/keysym2ucs.cpp PRE-CREATION =
> kcontrol/keyboard/preview/keysymbols.h PRE-CREATION =
> kcontrol/keyboard/preview/keysymbols.cpp PRE-CREATION =
> kcontrol/keyboard/preview/keysymhelper.h PRE-CREATION =
> kcontrol/keyboard/preview/keysymhelper.cpp PRE-CREATION =
> kcontrol/keyboard/x11_helper.cpp fdadeeb851bac7511dc924a310c02f6f8a76bc=
84 =
> =
> Diff: http://git.reviewboard.kde.org/r/107202/diff/
> =
> =
> Testing
> -------
> =
> =
> Screenshots
> -----------
> =
> Keyboard Layout Preview
> http://git.reviewboard.kde.org/r/107202/s/813/
> =
> =
> Thanks,
> =
> Andriy Rysin
> =
>
[Attachment #3 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/107202/">http://git.reviewboard.kde.org/r/107202/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Was this review? I \
don't see the ship it.
Also, kde-workspace is not compiling right now because: /keyboardpainter.cpp:20:32: \
fatal error: ui_keyboardpainter.h: No such file...</pre> <br />
<p>- Àlex</p>
<br />
<p>On November 6th, 2012, 4:53 a.m., Andriy Rysin wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for KDE Runtime and Shaun Reich.</div>
<div>By Andriy Rysin.</div>
<p style="color: grey;"><i>Updated Nov. 6, 2012, 4:53 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Keyboard layout preview feature</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kcontrol/keyboard/CMakeLists.txt <span style="color: \
grey">(29de717975d37949448a922c2297674a796a97c1)</span></li>
<li>kcontrol/keyboard/Messages.sh <span style="color: \
grey">(0779aacf810c086c424d4ff946bbcb800492eb84)</span></li>
<li>kcontrol/keyboard/kcm_add_layout_dialog.h <span style="color: \
grey">(6c6a795161d95d5203b5943ead6a7787e29ffd67)</span></li>
<li>kcontrol/keyboard/kcm_add_layout_dialog.cpp <span style="color: \
grey">(34c97163d9267da34ad948347f7cc35b556fdaeb)</span></li>
<li>kcontrol/keyboard/kcm_add_layout_dialog.ui <span style="color: \
grey">(b73080d08d6281c4f67d079ab016a3df50821012)</span></li>
<li>kcontrol/keyboard/kcm_keyboard.ui <span style="color: \
grey">(22968e8644cae700efe505fde437d332aa9514ed)</span></li>
<li>kcontrol/keyboard/kcm_keyboard_widget.h <span style="color: \
grey">(fa912c7f7daa497c20e3ce7ec4e40882d7d980af)</span></li>
<li>kcontrol/keyboard/kcm_keyboard_widget.cpp <span style="color: \
grey">(e1bd830bca8d308470dbba40e5e5a0127672798b)</span></li>
<li>kcontrol/keyboard/preview/TODO <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>kcontrol/keyboard/preview/kbpreviewframe.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>kcontrol/keyboard/preview/kbpreviewframe.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>kcontrol/keyboard/preview/keyaliases.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>kcontrol/keyboard/preview/keyaliases.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>kcontrol/keyboard/preview/keyboardlayout.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>kcontrol/keyboard/preview/keyboardlayout.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>kcontrol/keyboard/preview/keyboardpainter.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>kcontrol/keyboard/preview/keyboardpainter.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>kcontrol/keyboard/preview/keysym2ucs.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>kcontrol/keyboard/preview/keysym2ucs.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>kcontrol/keyboard/preview/keysymbols.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>kcontrol/keyboard/preview/keysymbols.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>kcontrol/keyboard/preview/keysymhelper.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>kcontrol/keyboard/preview/keysymhelper.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>kcontrol/keyboard/x11_helper.cpp <span style="color: \
grey">(fdadeeb851bac7511dc924a310c02f6f8a76bc84)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/107202/diff/" style="margin-left: \
3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Screenshots </h1>
<div>
<a href="http://git.reviewboard.kde.org/r/107202/s/813/"><img \
src="http://git.reviewboard.kde.org/media/uploaded/images/2012/11/04/keyboard_layout_preview_400x100.png" \
style="border: 1px black solid;" alt="Keyboard Layout Preview" /></a>
</div>
</td>
</tr>
</table>
</div>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic