[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-core-devel
Subject: Re: Review Request: remove an assert
From: "Jaime Torres Amate" <jtamate () gmail ! com>
Date: 2012-11-06 9:08:36
Message-ID: 20121106090836.2983.89045 () vidsolbach ! de
[Download RAW message or body]
> On Nov. 6, 2012, 6:46 a.m., David Edmundson wrote:
> > The responsibility of deleting d->rootDir seems to lie within KArchive.=
Therefore by setting the rootDir twice either implicitly or explicitly (wh=
ich this assert is designed to avoid) you risk leaking the first KArchiveDi=
rectory object. =
> > =
> > I think you need something more involved than just removing the checks.
The problem comes from ktar.cpp, line 472 after finding a "." directory ent=
ry in a .tar file.
For example, the kdevelop ruby templates at $KDE_INSTALL_DIR/share/apps/kde=
vappwizard/templates/kderubyapp.tar.bz2
- Jaime Torres
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107211/#review21475
-----------------------------------------------------------
On Nov. 5, 2012, 2:47 p.m., Jaime Torres Amate wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107211/
> -----------------------------------------------------------
> =
> (Updated Nov. 5, 2012, 2:47 p.m.)
> =
> =
> Review request for kdelibs.
> =
> =
> Description
> -------
> =
> I've suffered this assert starting kdevelop.
> The assert and the comment are no longer valid, as the rootDir can be set=
also calling rootDir, not only setRootDir.
> =
> =
> Diffs
> -----
> =
> kdecore/io/karchive.cpp 43539e3 =
> =
> Diff: http://git.reviewboard.kde.org/r/107211/diff/
> =
> =
> Testing
> -------
> =
> avoid an unnecesary debug crash.
> =
> =
> Thanks,
> =
> Jaime Torres Amate
> =
>
[Attachment #3 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/107211/">http://git.reviewboard.kde.org/r/107211/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On November 6th, 2012, 6:46 a.m., <b>David \
Edmundson</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">The responsibility of deleting d->rootDir seems to lie within \
KArchive. Therefore by setting the rootDir twice either implicitly or explicitly \
(which this assert is designed to avoid) you risk leaking the first KArchiveDirectory \
object.
I think you need something more involved than just removing the checks.</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The problem comes from \
ktar.cpp, line 472 after finding a "." directory entry in a .tar file. For \
example, the kdevelop ruby templates at \
$KDE_INSTALL_DIR/share/apps/kdevappwizard/templates/kderubyapp.tar.bz2 </pre>
<br />
<p>- Jaime Torres</p>
<br />
<p>On November 5th, 2012, 2:47 p.m., Jaime Torres Amate wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kdelibs.</div>
<div>By Jaime Torres Amate.</div>
<p style="color: grey;"><i>Updated Nov. 5, 2012, 2:47 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">I've suffered this assert starting kdevelop. The assert and the \
comment are no longer valid, as the rootDir can be set also calling rootDir, not only \
setRootDir. </pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">avoid an unnecesary debug crash.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kdecore/io/karchive.cpp <span style="color: grey">(43539e3)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/107211/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic