--===============8520154941116326670== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107048/ ----------------------------------------------------------- (Updated Oct. 30, 2012, 7:49 p.m.) Review request for KDE Base Apps and David Faure. Changes ------- Updated description. Description (updated) ------- The attached patch is an attempt to fix the bug where opening certain types= of documents in a background tab results in the new tab being activated in= advertently. The issue can be reproduced by simply attempting to open a PDF document usi= ng either the MMB or the CTRL+LMB button in Konqueror. If you have a local = PDF file simply navigate to the location of the file and click on it using = the MMB. Otherwise, see the aforementioned bug report for a site with PDF l= inks in it. If the "Open new tabs in background" option is checked when you= clicked on the PDF document, then the PDF document is opened embedded in K= onqueror tab in the background. However, this background tab should not be = activated when the aforementioned option is enabled. = Unfortunately, in the currently implementation the background tab will get = activated if the part used to handle the resource (PDF file in this case) i= ssues a FocusIn event, for example by calling setFocus. That is because KPa= rt::PartManager installs an event filter on all the KParts it manages, list= ens for FocusIn events, and invokes KParts::PartManager::setActivatePart. This addresses bug 306417. http://bugs.kde.org/show_bug.cgi?id=3D306417 Diffs ----- konqueror/src/konqviewmanager.cpp c8e3cb0 = Diff: http://git.reviewboard.kde.org/r/107048/diff/ Testing ------- - Tested opening a PDF file when the "Open new tabs in background" option i= s checked. - Tested opening a PDF file when the "Open new tabs in background" option i= s UNchecked. - Tested opening a PDF link from a webpage using both the MMB and CTRL+LMB. Thanks, Dawit Alemayehu --===============8520154941116326670== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable
This is an automatically generated e-mail. To reply, visit: http://git.revie= wboard.kde.org/r/107048/

Review request for KDE Base Apps and David Faure.
By Dawit Alemayehu.

Updated Oct. 30, 2012, 7:49 p.m.

Changes 
Updated description.

Descripti= on (updated)

The attached patch is an attempt to fix the bug where openin=
g certain types of documents in a background tab results in the new tab bei=
ng activated inadvertently.

The issue can be reproduced by simply attempting to open a PDF document usi=
ng either the MMB or the CTRL+LMB button in Konqueror. If you have a local =
PDF file simply navigate to the location of the file and click on it using =
the MMB. Otherwise, see the aforementioned bug report for a site with PDF l=
inks in it. If the "Open new tabs in background" option is checke=
d when you clicked on the PDF document, then the PDF document is opened emb=
edded in Konqueror tab in the background. However, this background tab shou=
ld not be activated when the aforementioned option is enabled. =


Unfortunately, in the currently implementation the background tab will get =
activated if the part used to handle the resource (PDF file in this case) i=
ssues a FocusIn event, for example by calling setFocus. That is because KPa=
rt::PartManager installs an event filter on all the KParts it manages, list=
ens for FocusIn events, and invokes KParts::PartManager::setActivatePart.

Testing <= /h1> 
- Tested opening a PDF file when the "Open new tabs in =
background" option is checked.
- Tested opening a PDF file when the "Open new tabs in background"=
; option is UNchecked.
- Tested opening a PDF link from a webpage using both the MMB and CTRL+LMB.=
Bugs: 306417

Diffs=

  • konqueror/src/konqviewmanager.cpp (c8e3cb0= )

View Diff
--===============8520154941116326670==--