[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: Moving libkfacebook to extragear
From:       Martin Klapetek <martin.klapetek () gmail ! com>
Date:       2012-10-29 9:35:59
Message-ID: CAPLgePqzJOh3kNfaozrgKp3XqDR_UqWAskFqA+b6=B0RD+8+ww () mail ! gmail ! com
[Download RAW message or body]

On Mon, Oct 29, 2012 at 8:28 AM, Kevin Krammer <krammer@kde.org> wrote:

>
> I think you can remove m_accessToken, m_path and m_queryItems from
> FacebookJob.
> Access token and path are already set on m_url and addQueryItem can be
> implemented to just call m_url.addQueryItem().
>
> Also, virtual void start() = 0 is already part of KJob's API, so not needed
> again.
>

Good points, all fixed.

Cheers
-- 
Martin Klapetek | KDE Developer

[Attachment #3 (text/html)]

On Mon, Oct 29, 2012 at 8:28 AM, Kevin Krammer <span dir="ltr">&lt;<a href="mailto:krammer@kde.org" \
target="_blank">krammer@kde.org</a>&gt;</span> wrote:<br><div class="gmail_quote"><blockquote \
class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">

<div class="im"><br>
</div>I think you can remove m_accessToken, m_path and m_queryItems from<br>
FacebookJob.<br>
Access token and path are already set on m_url and addQueryItem can be<br>
implemented to just call m_url.addQueryItem().<br>
<br>
Also, virtual void start() = 0 is already part of KJob&#39;s API, so not needed<br>
again.<br></blockquote><div><br></div><div>Good points, all \
fixed.</div><div><br></div><div>Cheers</div></div>-- <br><div><span style="color:rgb(102,102,102)">Martin \
Klapetek | KDE  Developer</span></div><br>



[prev in list] [next in list] [prev in thread] [next in thread]