[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: Moving libkfacebook to extragear
From:       Martin Klapetek <martin.klapetek () gmail ! com>
Date:       2012-10-28 23:11:03
Message-ID: CAPLgePoHC-S8Wn+eKO8zLJdGqH8FwtSW2VKVRPFDxtrTy20rsQ () mail ! gmail ! com
[Download RAW message or body]

On Sun, Oct 28, 2012 at 8:03 PM, Kevin Krammer <krammer@kde.org> wrote:

>
> > This is for the parsing purposes - the library uses QJson parser/mapper,
> > which automagically maps the received json data to qobjects, otherwise
> > there would have to be manual parsing everywhere (and the facebook jsons
> > are huge), which means more code, more error possibilities, more
> > maintaining requirement and worse readability (compared to two lines
> QJson
> > mapper). So I'd like to leave this one as is.
>
> I haven't had a look at the QJson library internals (yet), but from its
> usage
> it looks like that it is only using instances of those QObject classes to
> provide a convenient mapper of map keys to conversion functions (the
> property
> setters).
>
> This would make them an internal implementation detail, something more
> convenient than manually writing a mapping of string to function pointer
> but
> also just private.
>
> As I said I'll have a look into QJson, but unless I am gravely mistaken it
> only needs such QObjects as a generic accessor API, not as the actual data
> object.
>

Thanks. I fixed all the issues you pointed out except this one.

Also I checked for the naming and here's what I found [1]:

  6. You may not combine our Brand Assets, or elements of our Brand Assets,
with your own name or mark or generic terms.

So if "lib" is a generic term, "k" is sort of our mark, I guess
"libkfacebook" is pretty much off limits, right? Either way, we might be
just better off changing the name and rest calm. I'm thinking going in
steps of "libkgapi" - "libkfbapi". Thoughts?

[1] - https://www.facebook.com/brandpermissions/logos.php

Cheers
-- 
Martin Klapetek | KDE Developer

[Attachment #3 (text/html)]

On Sun, Oct 28, 2012 at 8:03 PM, Kevin Krammer <span dir="ltr">&lt;<a href="mailto:krammer@kde.org" \
target="_blank">krammer@kde.org</a>&gt;</span> wrote:<br><div class="gmail_quote"><blockquote \
class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">

<div class="im"><br></div><div class="im">
&gt; This is for the parsing purposes - the library uses QJson parser/mapper,<br>
&gt; which automagically maps the received json data to qobjects, otherwise<br>
&gt; there would have to be manual parsing everywhere (and the facebook jsons<br>
&gt; are huge), which means more code, more error possibilities, more<br>
&gt; maintaining requirement and worse readability (compared to two lines QJson<br>
&gt; mapper). So I&#39;d like to leave this one as is.<br>
<br>
</div>I haven&#39;t had a look at the QJson library internals (yet), but from its usage<br>
it looks like that it is only using instances of those QObject classes to<br>
provide a convenient mapper of map keys to conversion functions (the property<br>
setters).<br>
<br>
This would make them an internal implementation detail, something more<br>
convenient than manually writing a mapping of string to function pointer but<br>
also just private.<br>
<br>
As I said I&#39;ll have a look into QJson, but unless I am gravely mistaken it<br>
only needs such QObjects as a generic accessor API, not as the actual data<br>
object.<br></blockquote><div><br></div><div>Thanks. I fixed all the issues you pointed out except this \
one.</div><div><br></div><div>Also I checked for the naming and here&#39;s what I found \
[1]:</div><div><br></div><div>

   6. You may not combine our Brand Assets, or elements of our Brand Assets, with your own name or mark \
or generic terms.</div><div><br></div><div>So if &quot;lib&quot; is a generic term, &quot;k&quot; is sort \
of our mark, I guess &quot;libkfacebook&quot; is pretty much off limits, right? Either way, we might be \
just better off changing the name and rest calm. I&#39;m thinking going in steps of &quot;libkgapi&quot; \
- &quot;libkfbapi&quot;. Thoughts?</div>

<div><br></div><div>[1] -  <a \
href="https://www.facebook.com/brandpermissions/logos.php">https://www.facebook.com/brandpermissions/logos.php</a></div><div><br></div><div>Cheers</div></div>-- \
<br><div><span style="color:rgb(102,102,102)">Martin Klapetek | KDE  Developer</span></div>

<br>



[prev in list] [next in list] [prev in thread] [next in thread]