[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-core-devel
Subject: Re: Review Request: Keep KService::createInstance error message in KServiceTypeTrader::createInstanc
From: "Commit Hook" <null () kde ! org>
Date: 2012-10-26 1:18:40
Message-ID: 20121026011840.8024.88608 () vidsolbach ! de
[Download RAW message or body]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107032/#review20933
-----------------------------------------------------------
This review has been submitted with commit c78c13973ab47a79dc0a515fb891d632=
8808344f by Milian Wolff to branch KDE/4.10.
- Commit Hook
On Oct. 25, 2012, 12:12 a.m., Milian Wolff wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107032/
> -----------------------------------------------------------
> =
> (Updated Oct. 25, 2012, 12:12 a.m.)
> =
> =
> Review request for kdelibs and David Faure.
> =
> =
> Description
> -------
> =
> When KServiceTypeTrader::createInstanceFromQuery fails in KService::creat=
eInstance, the error message is currently overwritten by the useless inform=
ation "No service matching the requirements was found". This patch fixes th=
at to keep the error message set by KService::createInstance and thus give =
me something more useful like e.g. "Cannot load library /home/milian/projec=
ts/compiled/kde4/lib/kde4/kdevqmljslanguagesupport.so: (libqtc-qmlsupport.s=
o: cannot open shared object file: No such file or directory)" ' =
> =
> =
> Diffs
> -----
> =
> kdecore/services/kservicetypetrader.h 8641fe6 =
> =
> Diff: http://git.reviewboard.kde.org/r/107032/diff/
> =
> =
> Testing
> -------
> =
> changed the header, ran KDevelop with invalid plugins, got actually usefu=
l output (see above). Another example that was overwritten as well before t=
his patch:
> =
> "Cannot load library /home/milian/projects/compiled/kde4/lib/kde4/kdevfil=
etemplates.so: (/home/milian/projects/compiled/kde4/lib/kde4/kdevfiletempla=
tes.so: undefined symbol: _ZTIN8KDevelop17ITemplateProviderE)" ' =
> =
> =
> Thanks,
> =
> Milian Wolff
> =
>
[Attachment #3 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/107032/">http://git.reviewboard.kde.org/r/107032/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been \
submitted with commit c78c13973ab47a79dc0a515fb891d6328808344f by Milian Wolff to \
branch KDE/4.10.</pre> <br />
<p>- Commit</p>
<br />
<p>On October 25th, 2012, 12:12 a.m., Milian Wolff wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kdelibs and David Faure.</div>
<div>By Milian Wolff.</div>
<p style="color: grey;"><i>Updated Oct. 25, 2012, 12:12 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">When KServiceTypeTrader::createInstanceFromQuery fails in \
KService::createInstance, the error message is currently overwritten by the useless \
information "No service matching the requirements was found". This patch \
fixes that to keep the error message set by KService::createInstance and thus give me \
something more useful like e.g. "Cannot load library \
/home/milian/projects/compiled/kde4/lib/kde4/kdevqmljslanguagesupport.so: \
(libqtc-qmlsupport.so: cannot open shared object file: No such file or \
directory)" ' </pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">changed the header, ran KDevelop with invalid plugins, got actually \
useful output (see above). Another example that was overwritten as well before this \
patch:
"Cannot load library \
/home/milian/projects/compiled/kde4/lib/kde4/kdevfiletemplates.so: \
(/home/milian/projects/compiled/kde4/lib/kde4/kdevfiletemplates.so: undefined symbol: \
_ZTIN8KDevelop17ITemplateProviderE)" ' </pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kdecore/services/kservicetypetrader.h <span style="color: \
grey">(8641fe6)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/107032/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic