[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-core-devel
Subject: Re: Review Request: Cache icon and accessibility in KFilePlacesItem
From: "Christoph Feck" <christoph () maxiom ! de>
Date: 2012-10-24 23:33:24
Message-ID: 20121024233324.10797.55178 () vidsolbach ! de
[Download RAW message or body]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107030/#review20831
-----------------------------------------------------------
Ship it!
On a second look, I see no cluttering.
- Christoph Feck
On Oct. 24, 2012, 9:13 p.m., Dan Vr=C3=A1til wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107030/
> -----------------------------------------------------------
> =
> (Updated Oct. 24, 2012, 9:13 p.m.)
> =
> =
> Review request for kdelibs.
> =
> =
> Description
> -------
> =
> Similar to what Dolphin does in the "Places" pane, the open/save dialog s=
hould cache devices' icons, emblems and whether it's accessible, rather the=
n querying Solid::Device all the time. Querying can cause Solid to ask udis=
ksd to enumerate all devices (because with udisksd2 you can't ask for just =
a single device), which can take a lot of time (especially when slow device=
s like NFS shares or slow USB sticks are present).
> =
> Since this is a model item, the values are queried quite a lot, causing h=
igh CPU load from udiskds and the calling application blocks. Just try to q=
uickly move mouse over Solid devices in the open/save dialog and what your =
CPU load).
> =
> Most visible result of this caching is that the dialog is presented faste=
r and you can smoothly resize the "Places" pane.
> =
> Lukas Tinkl will try to optimize the Solid Udisks backend a bit to make i=
t even faster, as this problem with device icons causing querying udisksd h=
as impact on Dolphin start up time (and with this patch it has similar impa=
ct on the dialog show-up time).
> =
> =
> Diffs
> -----
> =
> kfile/kfileplacesitem.cpp 3ada0c3 =
> kfile/kfileplacesitem_p.h 3c6bd30 =
> =
> Diff: http://git.reviewboard.kde.org/r/107030/diff/
> =
> =
> Testing
> -------
> =
> =
> Thanks,
> =
> Dan Vr=C3=A1til
> =
>
[Attachment #3 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/107030/">http://git.reviewboard.kde.org/r/107030/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">On a second look, I see \
no cluttering.</pre> <br />
<p>- Christoph</p>
<br />
<p>On October 24th, 2012, 9:13 p.m., Dan Vrátil wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kdelibs.</div>
<div>By Dan Vrátil.</div>
<p style="color: grey;"><i>Updated Oct. 24, 2012, 9:13 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Similar to what Dolphin does in the "Places" pane, the \
open/save dialog should cache devices' icons, emblems and whether it's \
accessible, rather then querying Solid::Device all the time. Querying can cause Solid \
to ask udisksd to enumerate all devices (because with udisksd2 you can't ask for \
just a single device), which can take a lot of time (especially when slow devices \
like NFS shares or slow USB sticks are present).
Since this is a model item, the values are queried quite a lot, causing high CPU load \
from udiskds and the calling application blocks. Just try to quickly move mouse over \
Solid devices in the open/save dialog and what your CPU load).
Most visible result of this caching is that the dialog is presented faster and you \
can smoothly resize the "Places" pane.
Lukas Tinkl will try to optimize the Solid Udisks backend a bit to make it even \
faster, as this problem with device icons causing querying udisksd has impact on \
Dolphin start up time (and with this patch it has similar impact on the dialog \
show-up time).</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kfile/kfileplacesitem.cpp <span style="color: grey">(3ada0c3)</span></li>
<li>kfile/kfileplacesitem_p.h <span style="color: grey">(3c6bd30)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/107030/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic